chore(Badge): update tests to new react testing library standards#8082
Merged
nicolethoen merged 2 commits intopatternfly:mainfrom Sep 29, 2022
Merged
chore(Badge): update tests to new react testing library standards#8082nicolethoen merged 2 commits intopatternfly:mainfrom
nicolethoen merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-8082.surge.sh A11y report: https://patternfly-react-pr-8082-a11y.surge.sh |
wise-king-sullyman
requested changes
Sep 26, 2022
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
This looks great! I just have one small thing I'd like to be changed and it should be good to go!
packages/react-core/src/components/Badge/__tests__/Badge.test.tsx
Outdated
Show resolved
Hide resolved
wise-king-sullyman
approved these changes
Sep 27, 2022
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Looks perfect!
nicolethoen
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7994
Additional issues: