chore(Accordion): update tests to new standards#7645
Merged
nicolethoen merged 2 commits intopatternfly:mainfrom Jul 11, 2022
Merged
chore(Accordion): update tests to new standards#7645nicolethoen merged 2 commits intopatternfly:mainfrom
nicolethoen merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7645.surge.sh A11y report: https://patternfly-react-pr-7645-a11y.surge.sh |
nicolethoen
approved these changes
Jul 5, 2022
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
LGTM!
And you may not love the nodeName property, but I imagine we'll be using it often whenever we have a configurable element - like heading levels and things like that.
kmcfaul
approved these changes
Jul 8, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
* chore(Accordion): update tests to new standards * fix demo app errors from incomplete integration test removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7605
Additional issues: