chore(NotificationBadge):convert examples to typescript#7636
Merged
nicolethoen merged 2 commits intopatternfly:mainfrom Jul 6, 2022
janwright73:notification_badge
Merged
chore(NotificationBadge):convert examples to typescript#7636nicolethoen merged 2 commits intopatternfly:mainfrom janwright73:notification_badge
nicolethoen merged 2 commits intopatternfly:mainfrom
janwright73:notification_badge
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7636.surge.sh A11y report: https://patternfly-react-pr-7636-a11y.surge.sh |
gitdallas
reviewed
Jun 30, 2022
packages/react-core/src/components/NotificationBadge/examples/NotificationBadgeWithCount.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
"Count (optional): When used, the count field will indicate the number of notifications in the notification drawer." I am totally fine with the count decreasing instead of increasing. How about going from 30 to 10? |
nicolethoen
approved these changes
Jul 5, 2022
gitdallas
approved these changes
Jul 5, 2022
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7630
Additional issues: