refactor(Hint): Convert hint examples to typescript#7487
Merged
tlabaj merged 2 commits intopatternfly:mainfrom Jun 7, 2022
Merged
refactor(Hint): Convert hint examples to typescript#7487tlabaj merged 2 commits intopatternfly:mainfrom
tlabaj merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7487.surge.sh A11y report: https://patternfly-react-pr-7487-a11y.surge.sh |
bartoval
requested review from
kmcfaul,
thatblindgeye,
tlabaj and
wise-king-sullyman
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Only had a couple of nitpicks below, but otherwise it's looking good!
| KebabToggle | ||
| } from '@patternfly/react-core'; | ||
|
|
||
| export const BasicHint: React.FunctionComponent = () => { |
Contributor
There was a problem hiding this comment.
Nit: for the most part the exported component name within files usually matches the file name, so this would be export const HintBasicWithTitle....
| KebabToggle | ||
| } from '@patternfly/react-core'; | ||
|
|
||
| export const BasicHint: React.FunctionComponent = () => { |
Contributor
There was a problem hiding this comment.
Similar nitpick to the previous comment re: the exported component name matching the file name
thatblindgeye
approved these changes
Jun 2, 2022
wise-king-sullyman
approved these changes
Jun 3, 2022
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Looks great! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7482