Docs: expose menuAppendTo in prop docs#7435
Merged
tlabaj merged 3 commits intopatternfly:mainfrom May 25, 2022
Merged
Conversation
jenny-s51
force-pushed
the
iss6985
branch
2 times, most recently
from
4aa40fa to
18c09e4
Compare
Collaborator
|
Preview: https://patternfly-react-pr-7435.surge.sh A11y report: https://patternfly-react-pr-7435-a11y.surge.sh |
thatblindgeye
approved these changes
May 19, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #6985
This is a workaround to expose the
menuAppendToprop until we have a breaking change release.ToggleBaseMenuPropswas deleted and merged in #7173, though it later became evident that this was a breaking change for Keycloak which had this prop publicly exposed (they no longer do, however).Folow-up work will involve removing the
ToggleMenuBasePropsinterface (#7438) in our upcoming major release -- I've marked it deprecated in this PR and opened related issue #7438Convenience links to components for which
menuAppendToprop is listed: