Add correct types to instances of useCallback#7216
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Apr 13, 2022
Merged
Add correct types to instances of useCallback#7216nicolethoen merged 1 commit intopatternfly:mainfrom
nicolethoen merged 1 commit intopatternfly:mainfrom
Conversation
20 tasks
Collaborator
|
Preview: https://patternfly-react-pr-7216.surge.sh A11y report: https://patternfly-react-pr-7216-a11y.surge.sh |
nicolethoen
approved these changes
Apr 12, 2022
Contributor
|
@jeff-phillips-18 I tagged you for review here since there are some topology updates I'd love you to sanity check :) |
jeff-phillips-18
approved these changes
Apr 12, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds correct type information to instances of
useCallbackto prevent implicitanyerrrors. This type has been tightened in React 18 so this is needed to land #7142.