docs(Tabs): add tables and tabs auto width tabs demo#7183
docs(Tabs): add tables and tabs auto width tabs demo#7183nicolethoen merged 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-7183.surge.sh A11y report: https://patternfly-react-pr-7183-a11y.surge.sh |
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
LGTM. Thanks @wise-king-sullyman !
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
LGTM overall just a minor question about prop name which I'd be happy with either way.
| /** Enables vertical tab styling */ | ||
| isVertical?: boolean; | ||
| /** Enables no border bottom tab styling */ | ||
| hasNoBorderBottom?: boolean; |
There was a problem hiding this comment.
Not a blocker but I wonder whether the prop should be called hasBorderBottom with a false value instead of hasNoBorderBottom with a true value? I know the css prop is called noBorderBottom but I feel like I don't see "no{X}" props as much.
There was a problem hiding this comment.
Yeah I also didn't like that prop name here for that reason, but having it not match the class name also didn't feel ideal. If you prefer that route though I'm 100% on board.
There was a problem hiding this comment.
I think making it feel more intuitive to the consumer might be better than making it match the core class name. Im in support of avoiding the double negative.
|
Could you add a sentence or two in the docs to clarify what this demo is highlighting? |
7 participants
What: Closes #6860
This PR also adds a prop to apply the
noBorderBottomstyling as needed by the associated demo, and a test to verify that prop works as expected.Additional issues:
Convenience link directly to the added demo: https://patternfly-react-pr-7183.surge.sh/components/tabs/react-demos/tables-and-tabs-auto-width-tabs/