chore(code block): Convert examples to TypeScript/Functional components#7086
Merged
nicolethoen merged 2 commits intopatternfly:mainfrom Mar 23, 2022
Merged
chore(code block): Convert examples to TypeScript/Functional components#7086nicolethoen merged 2 commits intopatternfly:mainfrom
nicolethoen merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7086.surge.sh A11y report: https://patternfly-react-pr-7086-a11y.surge.sh |
nicolethoen
reviewed
Mar 19, 2022
| --- | ||
|
|
||
| import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon'; | ||
| import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; |
Contributor
There was a problem hiding this comment.
I think the build is failing because you will need to add these back. It's a weird quirk, but the icons needed in any of the examples need to be additionally imported at the beginning of our example files.
Contributor
Author
There was a problem hiding this comment.
Thank you @nicolethoen - that is a weird quirk! I've added these imports back in as suggested 👍
nicolethoen
approved these changes
Mar 21, 2022
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
This looks good to me!
I did open an issue: #7096 to fix the copy to clipboard tooltip when using a screen reader. But this was an issue before this PR.
kmcfaul
approved these changes
Mar 23, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7074