chore(react): Update react and react-dom pkg dependencies to 18.0.0-rc.0#6899
Closed
dlabrecq wants to merge 1 commit intopatternfly:pf-react18from
Closed
chore(react): Update react and react-dom pkg dependencies to 18.0.0-rc.0#6899dlabrecq wants to merge 1 commit intopatternfly:pf-react18from
dlabrecq wants to merge 1 commit intopatternfly:pf-react18from
Conversation
Collaborator
tlabaj
reviewed
Feb 7, 2022
dlabrecq
changed the title
dlabrecq
force-pushed
the
react-dependencies
branch
3 times, most recently
from
61d8ef8 to
a36b210
Compare
dlabrecq
force-pushed
the
react-dependencies
branch
from
9b3f940 to
1b438da
Compare
20 tasks
Contributor
Contributor
|
@tlabaj considering the lack of response and the ongoing work for React 18 support it might be a good idea to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests fail because there is no Enzyme adapter for React 18. May need to move to the React Testing Library?
See https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl