chore(Button): Convert examples to typescript#6796
chore(Button): Convert examples to typescript#6796wise-king-sullyman merged 2 commits intopatternfly:mainfrom
Conversation
jpuzz0
force-pushed
the
chore/button-examples-to-ts
branch
from
d04367a to
07fe9db
Compare
| isLoading={isPrimaryLoading} | ||
| variant="primary" | ||
| onClick={() => setIsPrimaryLoading(!isPrimaryLoading)} | ||
| {...(isPrimaryLoading && { spinnerAriaValueText: 'Loading' })} |
There was a problem hiding this comment.
This line is causing a problem when I hit the ts>>js button...
There was a problem hiding this comment.
The mechanism used to convert between TS and JS seems to break when spreading props (at least for Button). Can you point me to where we do the conversion so I can take a look?
There was a problem hiding this comment.
with about 70% confidence, I think that is what this line is supposed to do?
https://github.com/patternfly/patternfly-org/blob/main/packages/theme-patternfly-org/scripts/md/mdx-hast-to-jsx.js#L166
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Works great
issues with typescript -> javascript parsing will be resolved when this org PR merges. This PR does not need to be blocked.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
What: Closes #6793