fix(FileUpload): hid input of type file from AT#11438
Merged
mfrances17 merged 4 commits intopatternfly:mainfrom Feb 18, 2025
Merged
fix(FileUpload): hid input of type file from AT#11438mfrances17 merged 4 commits intopatternfly:mainfrom
mfrances17 merged 4 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11438.surge.sh A11y report: https://patternfly-react-pr-11438-a11y.surge.sh |
thatblindgeye
requested review from
nicolethoen,
tlabaj and
wise-king-sullyman
Contributor
Author
|
Putting do not merge label for now as it might be nice to try getting a fix for #11416 in while we still have the issue present in CI. |
thatblindgeye
force-pushed
the
iss11343_fileUpload_inputA11y
branch
from
0c65e1d to
69bcc40
Compare
nicolethoen
approved these changes
Jan 27, 2025
thatblindgeye
force-pushed
the
iss11343_fileUpload_inputA11y
branch
from
69bcc40 to
bf7376b
Compare
wise-king-sullyman
approved these changes
Feb 4, 2025
kmcfaul
approved these changes
Feb 13, 2025
Contributor
Author
|
#11544 bumps the a11y package with a fix that should catch a11y issues in untouched files moving forward. this PR is good to go in now. |
mfrances17
approved these changes
Feb 18, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Towards #11343
The input was not intended to be exposed to users to navigate to and was simply required for dropzone. Keeping it exposed ends up allowing it to be focused which when it is, focus ends up being lost on the page. There should be enough context elsewhere in the components to indicate file uploading capability.
To test, go to an example in both components and navigate via keyboard and VoiceOver. Via keyboard the focus shouldn't get lost when navigating through the component elements, and via VoiceOver you should not hear an announcement along the lines of "Choose a file: no file chosen" (this is the output from the input type="file" element).
Additional issues: