fix(Menu toggle): Remove pf-m-action modifier#11096
Merged
kmcfaul merged 4 commits intopatternfly:mainfrom Oct 2, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11096.surge.sh A11y report: https://patternfly-react-pr-11096-a11y.surge.sh |
dlabaj
reviewed
Oct 1, 2024
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
React code looks good to me.
kmcfaul
requested changes
Oct 1, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
Just a minor example update to get it working, otherwise lgtm. Slider also looks like it's acting fine on the preview.
packages/react-core/src/components/MenuToggle/examples/MenuToggleSplitButtonAction.tsx
Outdated
Show resolved
Hide resolved
wise-king-sullyman
approved these changes
Oct 2, 2024
kmcfaul
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11095
This PR does the following:
SplitButtonOptionsinterface and prop since it is no longer needed because there is no longer a variant. Consumers will now pass items directly tosplitButtonItemsprop