fix(DataList): Add dropdown and button actions to DataList#1079
fix(DataList): Add dropdown and button actions to DataList#1079dlabaj merged 1 commit intopatternfly:masterfrom boaz0:actions_datalist
Conversation
|
PatternFly-React preview: https://1079-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3879
💛 - Coveralls |
|
@boaz0 Please resolve conflicts. |
|
@tlabaj rebased. |
mcarrano
left a comment
There was a problem hiding this comment.
Looks fine to me, although I don't see an example with a dropdown. Are we talking about having a kabob?
|
Looks good to me, but should the dropdown at the end of a row default to use the align-right example as seen on https://pf-next.com/components/dropdown/examples/? |
karelhala
left a comment
There was a problem hiding this comment.
I don't think that passing button with kebab icon without any children is behavior described by core pattern.
packages/patternfly-4/react-core/src/components/DataList/DataListAction.js
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/DataList/DataListAction.js
Outdated
Show resolved
Hide resolved
christiemolloy
left a comment
There was a problem hiding this comment.
- In some of the examples, the kebabs aren't clickable, and are a different color from Core.
- In the example where there is a Delete button, what is the purpose of "Delete" should it actually remove the line? Right now, it isn't functioning.
|
@boaz0 what is the status of this PR? Looks like there are some outstanding comments from @christiemolloy that should be address? |
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
- Coverage 83.86% 83.85% -0.02%
==========================================
Files 556 557 +1
Lines 5857 5865 +8
Branches 12 12
==========================================
+ Hits 4912 4918 +6
- Misses 943 945 +2
Partials 2 2
Continue to review full report at Codecov.
|
karelhala
left a comment
There was a problem hiding this comment.
I like this implementation! Simple and straight forward.
christiemolloy
left a comment
There was a problem hiding this comment.
Thanks for applying the comments I made! Looks awesome
|
Thank you all for the patience and feedback. Appreciate it a lot. |
This is a follow-up to #927
Now you can add
DropdownorButtontoDataListAction.Please feel free to review the API, I did it as simple as I could but if you believe it needs another abstraction or logical layer, I would like to hear.
cc @jgiardino @jschuler @christiemolloy