feat(page): support for context selector in sidebar#10686
Merged
tlabaj merged 7 commits intopatternfly:v6from Jul 3, 2024
Merged
feat(page): support for context selector in sidebar#10686tlabaj merged 7 commits intopatternfly:v6from
tlabaj merged 7 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10686.surge.sh A11y report: https://patternfly-react-pr-10686-a11y.surge.sh |
Contributor
Author
|
@kmcfaul I pushed a couple of updates to |
thatblindgeye
approved these changes
Jul 3, 2024
tlabaj
approved these changes
Jul 3, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10681
Adds support for
isContextSelectorto<PageSidebarBody>, adds a demo just to show toggle/menu placement.Updates jump links toggle and tabs toggle from the button updates in core that wrap button text and icons in their own wrappers:
<Button icon=[...]>propConvenience links:
Things to follow up on before merging or as a follow up after it's merged:
<Dropdown>in the demo to a<Select>, or whatever is most appropriate.