feat(Pagination): Added wrapper around menu toggle#10662
Merged
thatblindgeye merged 1 commit intopatternfly:v6from Jul 16, 2024
Merged
feat(Pagination): Added wrapper around menu toggle#10662thatblindgeye merged 1 commit intopatternfly:v6from
thatblindgeye merged 1 commit intopatternfly:v6from
Conversation
tlabaj
requested review from
a team,
kmcfaul,
mattnolting and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-10662.surge.sh A11y report: https://patternfly-react-pr-10662-a11y.surge.sh |
wise-king-sullyman
approved these changes
Jul 2, 2024
nicolethoen
approved these changes
Jul 5, 2024
thatblindgeye
approved these changes
Jul 16, 2024
Contributor
There was a problem hiding this comment.
Core wise looks good, noticing in the PR preview the page-menu element is a flex container vs not in Core, but most likely due to the PR using older styles. Might be worth a codemod just to provide a warning that the markup has changed within Pagination's OptionsMenu if you wouldn't mind opening an issue
This was referenced Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10598
code mod issue: patternfly/pf-codemods#700