fix(expandable section): Fix uncaught exception#10659
Merged
dlabaj merged 1 commit intopatternfly:mainfrom Jul 8, 2024
Merged
Conversation
tlabaj
requested review from
a team,
kmcfaul and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-10659.surge.sh A11y report: https://patternfly-react-pr-10659-a11y.surge.sh |
wise-king-sullyman
approved these changes
Jul 2, 2024
nicolethoen
approved these changes
Jul 5, 2024
dlabaj
approved these changes
Jul 8, 2024
Comment on lines
+174
to
+175
| if (this.expandableContentRef) { | ||
| const { offsetWidth } = this.expandableContentRef.current; |
Contributor
There was a problem hiding this comment.
How does this fix work?
this.expandableContentRef is assigned as a class property:
expandableContentRef = React.createRef<HTMLDivElement>();
Therefore this.expandableContentRef is always an object. However expandableContentRef.current may be null.
Therefore shouldn't the fix be:
if (this.expandableContentRef.current) {
Contributor
Author
There was a problem hiding this comment.
You are right. when i originally pushed a change i had a check to current that is missing here. I will push nother fix so it is included in our up coming release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10410