feat(Modal): promoted next version#10358
Merged
tlabaj merged 2 commits intopatternfly:v6from Jun 6, 2024
Merged
Conversation
Closed
Collaborator
|
Preview: https://patternfly-react-pr-10358.surge.sh A11y report: https://patternfly-react-pr-10358-a11y.surge.sh |
This was referenced May 14, 2024
thatblindgeye
requested review from
a team and
wise-king-sullyman
and removed request for
a team
wise-king-sullyman
approved these changes
May 16, 2024
thatblindgeye
force-pushed
the
deprecateModal
branch
from
5dc20b5 to
b86c0d6
Compare
kmcfaul
approved these changes
Jun 4, 2024
tlabaj
requested changes
Jun 6, 2024
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
General comment. We should not be using the deprecated modal in our components or examples/demos. We can open a follow up issue for that.
| import { AboutModalBoxBrand } from './AboutModalBoxBrand'; | ||
| import { AboutModalBoxCloseButton } from './AboutModalBoxCloseButton'; | ||
| import { AboutModalBox } from './AboutModalBox'; | ||
| import { Modal, ModalVariant } from '../Modal'; |
Contributor
There was a problem hiding this comment.
we should be using the new modal here. I am ok with follow up issue to do that, but it should be done for Beta.
| Radio, | ||
| Popper | ||
| } from '@patternfly/react-core'; | ||
| import { Modal as ModalDeprecated, ModalVariant as ModalVariantDeprecated } from '@patternfly/react-core/deprecated'; |
| <Button onClick={() => setIsModalOpen(true)}>Show Modal</Button> | ||
|
|
||
| <Modal | ||
| <ModalDeprecated |
Contributor
There was a problem hiding this comment.
we should use new modal here.
Contributor
Author
|
In regards to above, followup created for updating examples: #10363 |
tlabaj
approved these changes
Jun 6, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8078
Additional issues: