feat(Drawer): consumed Penta updates#10036
Merged
tlabaj merged 6 commits intopatternfly:v6from Feb 1, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10036.surge.sh A11y report: https://patternfly-react-pr-10036-a11y.surge.sh |
thatblindgeye
requested review from
a team,
andrew-ronaldson,
lboehling,
mfrances17,
srambach and
wise-king-sullyman
and removed request for
a team
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Code all looks good, will have to circle back to this when surge is back up and running to finish the review though.
One small thing I saw that I think needs updating.
packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx
Outdated
Show resolved
Hide resolved
andrew-ronaldson
approved these changes
Jan 25, 2024
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Solid work, thanks
thatblindgeye
force-pushed
the
drawerPenta
branch
from
30b6ab3 to
3220691
Compare
kmcfaul
approved these changes
Jan 30, 2024
srambach
approved these changes
Feb 1, 2024
Member
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
Found a bug in core with the z-order, but this looks solid! 🗄️
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9979
Codemod: patternfly/pf-codemods#553
Additional issues: