feat(HelperText): consumed Penta updates#10029
Conversation
|
Preview: https://patternfly-react-pr-10029.surge.sh A11y report: https://patternfly-react-pr-10029-a11y.surge.sh |
bb80129 to
d7cb7b1
Compare
wise-king-sullyman
left a comment
There was a problem hiding this comment.
One non-blocking thought/potential discussion point but other than that looks great!
| export enum HelperTextItemVariant { | ||
| default = 'default', | ||
| warning = 'warning', | ||
| error = 'error', | ||
| success = 'success' | ||
| } |
There was a problem hiding this comment.
I feel like we use this same set of options in a good few places, I wonder if it would make sense for us to extract this kind of "status" enum/type into the constants file. Not a blocking thing, just a thought.
There was a problem hiding this comment.
Though how each component uses these variants can be slightly different. Here it's these 4 variants, Alert has danger | success | warning | info | custom, Progress only has dange | success | warning, etc. So it could also be a reason to make components follow a more universal variant naming when we can. At the very least, re-evaluating whether "error" should be used instead of danger in some places or vice versa, and whether ___Variant or ___Status makes more sense as an enum/prop name.
srambach
left a comment
There was a problem hiding this comment.
Looks good - created an issue to make the help icon button on form labels in examples to be the plain, no-padding button.
What: Closes #10005
Codemod: patternfly/pf-codemods#552
Helper text preview
Per discussion with @lboehling removed the isDynamic prop has the dynamic modifier isn't needed. This would require an update in Core to remove that modifier and its styling. Also removed the hasIcon prop has a default icon will now render automatically for variants other than "default"
We'll also want to update Core examples
Additional issues: