feat(NotificationBadge): refactor to use status buttons for penta#10020
Conversation
|
Preview: https://patternfly-react-pr-10020.surge.sh A11y report: https://patternfly-react-pr-10020-a11y.surge.sh |
wise-king-sullyman
requested review from
a team,
andrew-ronaldson,
lboehling,
mattnolting,
mfrances17 and
nicolethoen
and removed request for
a team
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
It looks like there is an extra pf-m-start class on the notification badges in the first example causing the icon to be slightly misaligned to the left?
|
@nicolethoen I think that might be more of a bug with button, but there are some ways we could resolve it NotificationBadge side. I could pass the icon as a child of the Button when there isn't a count, and to the I wonder if we should cut the flexibility of NotificationBadge back in penta since if a more custom solution is needed consumers can just customize the stateful Button themselves 🤔 |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
May be worth making a codemod just to warn consumers about the markup change
6 participants
What: Closes #9811
Additional issues:
Core is removing the notification badge, this PR internally replaces our notification badge with the button component while keeping the external API the same.
Convenience link: https://patternfly-react-pr-10020.surge.sh/components/notification-badge