fix(CodeBlock): Temporarily drop syntax highlighting#605
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Jul 28, 2025
Merged
fix(CodeBlock): Temporarily drop syntax highlighting#605rebeccaalpert merged 1 commit intopatternfly:mainfrom
rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-605.surge.sh A11y report: https://chatbot-pr-chatbot-605-a11y.surge.sh |
Syntax highlighter has a sub-dependency with a vulnerability. It has not yet been fixed. I would like to drop this for now and we can investigate a more PatternFly solution. This dependency was brought in by Rohit during early development.
thatblindgeye
approved these changes
Jul 16, 2025
nicolethoen
approved these changes
Jul 28, 2025
16 tasks
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
Syntax highlighter has a sub-dependency with a vulnerability. It has not yet been fixed. I would like to drop this for now and we can investigate a more PatternFly solution. This dependency was brought in by Rohit during early development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax highlighter has a sub-dependency with a vulnerability. It has not yet been fixed. I would like to drop this for now since it is purely visual and we can investigate a more PatternFly solution. This dependency was brought in by Rohit during early development. I honestly haven't seen many examples where LLMs were specifying the language in code blocks, and this would only impact code blocks with a specified language.
As an alternative, we can manually override some things and keep using this, but I'm concerned that it hasn't been a priority to merge fixes for this. There have been PRs up since March: https://github.com/react-syntax-highlighter/react-syntax-highlighter/pulls.