fix(handlebars-demo): move and modify the icon files#1377
Merged
JosefBredereck merged 1 commit intopattern-lab:devfrom Nov 21, 2021
Merged
fix(handlebars-demo): move and modify the icon files#1377JosefBredereck merged 1 commit intopattern-lab:devfrom
JosefBredereck merged 1 commit intopattern-lab:devfrom
Conversation
for pattern lab to both pick them up and copy them, as well as make them able to get referenced
JosefBredereck
approved these changes
Nov 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1376
Summary of changes:
To fix the "missing" / incorrectly referenced icon files on the handlebars demo page, I had to both move them to the images directory for pattern lab to copy them to the
publicfolder, as well as make them able to get referenced by setting an id within those files for the current mechanism of how they are getting included in the pages.