Skip to content

Initial JSBSimWrapper, ISA and airspeed blocks#1

Merged
milanofthe merged 6 commits intopathsim:mainfrom
seanmcleod70:InitialJSBSimISAAirspeeds
Mar 15, 2026
Merged

Initial JSBSimWrapper, ISA and airspeed blocks#1
milanofthe merged 6 commits intopathsim:mainfrom
seanmcleod70:InitialJSBSimISAAirspeeds

Conversation

@seanmcleod70
Copy link

No description provided.

@bcoconni
Copy link

bcoconni commented Mar 6, 2026

I guess a dependency to JSBSim ("jsbsim>=1.2.4") should be added to pyproject.toml:

dependencies = [
"pathsim",
"numpy>=1.15",
"scipy>=1.2",
]

@seanmcleod70
Copy link
Author

Thanks, just pushed a commit to add jsbsim as a dependency.

@milanofthe
Copy link
Member

Awesome @seanmcleod70!

A frew remarks:

  • Can you please put the helper classes and functions into a /utils dir, and add an __init__.py module that exposes the pathsim blocks at the package level?
  • It also makes sense to have a _constants.py module for all the constants that are used.
  • Also filenames are snake case in pathsim generally, so it makes sense to keep that convention here.

@seanmcleod70
Copy link
Author

Pushed a new commit to move the code into functional subdirectories, added relevant __init__.py files and changed filenames to match snake case pattern.

The only constants at the moment are specific to the International Standard Atmosphere, so I've left them as class variables of ISAtmosphere.

@milanofthe
Copy link
Member

Looks good. Do you have any thoughts on tests for the new blocks?

@seanmcleod70
Copy link
Author

So far I'd only been concentrating on getting the basics done to match the repo requirements etc. 😉

I'll take a look at the test setup for pathsim-chem and implement some tests along those lines and then push a commit to this PR with them.

@seanmcleod70
Copy link
Author

@milanofthe I've added an initial test for the ISAtmosphere block, mainly to confirm that I've set things up correctly for the automated test run via the Github workflow.

@milanofthe milanofthe merged commit 26c9abb into pathsim:main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants