docs: clarify that auto-approve self-mod bypass is no longer needed after #160#161
Merged
Merged
Conversation
…fter #160 The specific emergency procedure (bypass + --admin) for PRs that touch auto-approve.yml is no longer required. The landed fix ensures the review is submitted early and the workflow run succeeds. Updated wording in AGENTS.md (and cross-referenced skills) to reflect the resolution of #159. The general emergency hatch for other auto-approve breakage remains documented in ci-branch-protection. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
added a commit
that referenced
this pull request
Jun 22, 2026
Markdown-only changes (e.g. AGENTS.md, README, *.md) were triggering the entire CI matrix (unit tests x3, build, integration x3). - Added `changes` job using dorny/paths-filter (consistent with patchloom). - Jobs now always declare (so required status checks like "unit-test (ubuntu-latest)" report success) but early-exit with a cheap step when only non-code files changed on PRs. - On push/main, merge_group, etc. full runs still happen. - Filter includes source, tests, package files, tsconfig, actions, and ci.yml itself. Fixes unnecessary builds when changing one .md file (as seen in #161). See ci-workflow-hygiene and patchloom for the pattern. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
added a commit
that referenced
this pull request
Jun 23, 2026
Markdown-only changes (e.g. AGENTS.md, README, *.md) were triggering the entire CI matrix (unit tests x3, build, integration x3). - Added `changes` job using dorny/paths-filter (consistent with patchloom). - Jobs now always declare (so required status checks like "unit-test (ubuntu-latest)" report success) but early-exit with a cheap step when only non-code files changed on PRs. - On push/main, merge_group, etc. full runs still happen. - Filter includes source, tests, package files, tsconfig, actions, and ci.yml itself. Fixes unnecessary builds when changing one .md file (as seen in #161). See ci-workflow-hygiene and patchloom for the pattern. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specific 'use bypass for PRs touching auto-approve.yml' procedure is resolved by the resilience changes in #160.
The general emergency hatch for other auto-approve failures remains available.