refactor: handle issues #147 and #149 (complete helper migration + unit test for ensurePatchloomReadyOrNotify)#151
Merged
Conversation
… configureMcp/setup/verifyMcp (#147); improve testability and add unit test for helper (#149) - Updated remaining commands using the early-ready-notify pattern. - Moved vscode import inside notify branches (only when UI needed). - Added ensure test for success path (error paths require VSCode env). - Re-ran compile + unit tests: all green. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SebTardif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147
Closes #149
npm run checkpassed.For #148 (App perm), requires org admin action via GitHub settings (see issue); no code change possible here. Workaround not added to avoid weakening security.