AI junk#2202
Closed
muhamedfazalps wants to merge 1 commit into
Closed
Conversation
…ution The generated import statement in visit_Template directly interpolates module attribute names from jinja2.runtime.exported into Python code without sanitization. An attacker who can pollute these runtime lists could inject arbitrary Python code. Fix: validate each exported name is a valid Python identifier before using it in the generated import. Signed-off-by: Muhamed Fazal PS <fazaleee123cr7@gmail.com>
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated import statement in visit_Template directly interpolates module attribute names from jinja2.runtime.exported into Python code without sanitization. If an attacker can pollute these runtime lists via class pollution, they could inject arbitrary Python code.
This change adds a validation step that checks each exported name is a valid Python identifier (via str.isidentifier()) before using it in the generated import statement.
Closes #2197