AI junk#2200
Closed
mmustafasenoglu wants to merge 2 commits into
Closed
Conversation
When the indent filter is called with first=True and blank=False (the default), an empty first line was incorrectly indented. The blank=False flag should take precedence, skipping indentation for empty lines. Fixes #2176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #2176
When the
indentfilter is called withfirst=Trueandblank=False(the default), an empty first line was incorrectly indented.Fix
In
do_indent(), thefirst=Truebranch now checks if the result is non-empty (or ifblank=True) before adding indentation:This ensures
blank=Falsetakes precedence overfirst=Truefor empty lines.Test
Added
test_indent_first_empty_no_blankto verify empty strings are not indented whenfirst=Trueandblank=False.