Merged
Conversation
added 4 commits
January 16, 2025 11:30
srieckhof
commented
Jan 16, 2025
Contributor
arnold-iakab
left a comment
arnold-iakab
left a comment
There was a problem hiding this comment.
LGTM, just some small suggestions.
arnold-iakab
approved these changes
Jan 17, 2025
monstermunchkin
suggested changes
Jan 17, 2025
…n variable for it
monstermunchkin
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the instability of FSC in failover mode. By removing the call to lock.TTL() we don't run into panics inside redislock anymore and, thus, don't quit the Run() method anymore. Without lock.TTL() one pod is active and the other two are passive. This even holds after the active pod is killed. Test fuelings still work.
Also, I removed the noisy "Redis query" debug message from being logged. Instead, only errors on command execution are logged.