Skip to content

Reinstate "grantAccess" Logic#23

Merged
sebastianchristopher merged 5 commits intomasterfrom
AB#117017_patch_1
May 1, 2026
Merged

Reinstate "grantAccess" Logic#23
sebastianchristopher merged 5 commits intomasterfrom
AB#117017_patch_1

Conversation

@sebastianchristopher
Copy link
Copy Markdown
Contributor

@sebastianchristopher sebastianchristopher commented Apr 30, 2026

Move "grantAccess" logic to be consumer repo's responsibility (rather than called in auth setup).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the “grant access” flow needed for reliable Playwright-based deployment tests by centralizing shared URL + grant-access helpers into a new shared utility module and updating the build/CLI wiring accordingly.

Changes:

  • Replace src/shared/url.js with src/shared/util.js, combining URL helpers with grant-access + spinner/iframe helpers.
  • Update src/testUtils.js to consume/re-export helpers from shared/util.js (so tests regain grantAccessIfNeeded behavior).
  • Update the CLI (bin/auth.setup.js) and Vite library entrypoints to use the new util bundle.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.js Switch library entry from url to util so the new shared module is built into dist/.
src/testUtils.js Import URL builder from shared/util.js and re-export grant-access/iframe/spinner helpers.
src/shared/util.js New shared module containing URL normalization + grant-access helpers used by both tests and CLI.
src/shared/url.js Removed in favor of consolidated shared/util.js.
bin/auth.setup.js Use dist/util.js and invoke grantAccessIfNeeded when generating storageState.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 * remove shared `url.js`
 * move url to inline functions in `testUtils.js`
 * improve error handling in `auth.setup.js`
Copy link
Copy Markdown
Member

@buckett buckett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sebastianchristopher sebastianchristopher merged commit 7bc1458 into master May 1, 2026
1 check passed
@sebastianchristopher sebastianchristopher deleted the AB#117017_patch_1 branch May 1, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants