Open
Conversation
added 11 commits
May 7, 2015 22:20
smaller opcode for xor reg,reg
try to use shorter opcodes
rdx->rbx following the assumption in the comments
restore delimiter in eax
fix typo, change dec reg to sub reg, 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to convert all the xor reg, reg to the shorter form, and switched mov reg1, reg2 with reg2=0 to xor reg1, reg1 which has the same size (2 bytes) but is faster on almost all modern CPU.
In 64bitPutFileOnDisk the comments say that r8 should be equal to rbx, but it was set to 0 in the code, not sure what is the right thing to do.