Ship unminified file as ESM entrypoint#484
Closed
jasonkarns wants to merge 1 commit intooptimizely:masterfrom
Closed
Ship unminified file as ESM entrypoint#484jasonkarns wants to merge 1 commit intooptimizely:masterfrom
jasonkarns wants to merge 1 commit intooptimizely:masterfrom
Conversation
zashraf1985
added a commit
that referenced
this pull request
Apr 11, 2022
## Background This PR is copied from [484](#484). It was contributed by @jasonkarns a couple of years ago. I just pulled his changes, merged master and resolved conflicts. ## Summary ESM entrypoints are very very likely to be consumed by bundlers, not loaded directly into browsers. Therefore it is preferable that the bundlers have access to the unminified source so that consumers can have more control over the final output. ~~This change _adds_ an ESM output bundle that is not minified with terser.~~ (#477 has merged which also adds the unminified ES bundle, so this PR now just makes the unminified bundle the `module` entrypoint.) Notably, the unminified bundle is created _in addition to_ the minified bundle; so the minified bundle is still distributed with the package (at the same output location). This way users who do actually want the minified bundle may still use it. However, the `package.json#module` entrypoint is changed to reference the unminified bundle, as this is most likely what users will want when consuming from a bundler. (And bundlers are virtually the exclusive consumers of the `module` entrypoint.)
Contributor
|
Moved the work to #752 . Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESM entrypoints are very very likely to be consumed by bundlers, not loaded directly into browsers. Therefore it is preferable that the bundlers have access to the unminified source so that consumers can have more control over the final output.
This change adds an ESM output bundle that is not minified with terser.(#477 has merged which also adds the unminified ES bundle, so this PR now just makes the unminified bundle themoduleentrypoint.)Notably, the unminified bundle is created in addition to the minified bundle;
so the minified bundle is still distributed with the package (at the same output location).
This way users who do actually want the minified bundle may still use it.
However, the
package.json#moduleentrypoint is changed to reference the unminified bundle, as this is most likely what users will want when consuming from a bundler. (And bundlers are virtually the exclusive consumers of themoduleentrypoint.)