chore(ci): replace node target with v9/v10.0#101
Merged
tylerbrandt merged 2 commits intomasterfrom May 21, 2018
Merged
Conversation
Contributor
Author
|
NVM, it's not a Travis CI thing. nodejs@10.0 is fine but nodejs@10.1 reproduces the errors, on my system. |
tylerbrandt
changed the title
spencerwilson-optimizely
added a commit
that referenced
this pull request
Jul 3, 2018
## Summary - Re-enable CI against latest Node.js 10.x release It was disabled in #101, but from the [example failure](https://travis-ci.org/optimizely/javascript-sdk/jobs/380942404) given in that PR, I suspect the bug lies in lerna. No matter now, since lerna has been bypassed since #129. ## Test plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis is erroring (example) when the "node" or "10" target is given, but the tests are passing with node 10 (at least on my machine). Update "node" targets to "9"/"10.0" until this is resolved.
Mitigation for #102