[FSSDK-8795]chore: prepare for pre release 4.0.0-beta#515
Merged
Conversation
jaeopt
requested changes
May 4, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. A couple of suggestions.
CHANGELOG.md
Outdated
Comment on lines
19
to
32
| [#495](https://github.com/optimizely/java-sdk/pull/495), | ||
| [#496](https://github.com/optimizely/java-sdk/pull/496), | ||
| [#497](https://github.com/optimizely/java-sdk/pull/497), | ||
| [#498](https://github.com/optimizely/java-sdk/pull/498), | ||
| [#500](https://github.com/optimizely/java-sdk/pull/500), | ||
| [#501](https://github.com/optimizely/java-sdk/pull/501), | ||
| [#502](https://github.com/optimizely/java-sdk/pull/502), | ||
| [#503](https://github.com/optimizely/java-sdk/pull/503), | ||
| [#504](https://github.com/optimizely/java-sdk/pull/504), | ||
| [#509](https://github.com/optimizely/java-sdk/pull/509), | ||
| [#511](https://github.com/optimizely/java-sdk/pull/511), | ||
| [#512](https://github.com/optimizely/java-sdk/pull/512), | ||
| [#513](https://github.com/optimizely/java-sdk/pull/513), | ||
| [#514](https://github.com/optimizely/java-sdk/pull/514) |
Contributor
There was a problem hiding this comment.
This list is too long. Can we remove fix PRs (495-514), so can focus on new feature additions.
CHANGELOG.md
Outdated
|
|
||
| ### Breaking Changes | ||
| - `OdpManager` in the SDK is enabled by default, if initialized using OptimizelyFactory. Unless an ODP account is integrated into the Optimizely projects, most `OdpManager` functions will be ignored. If needed, `OdpManager` to be disabled initialize `OptimizelyClient` without passing `OdpManager`. | ||
| - `ProjectConfigManager` interface additions + implementing class updates |
Contributor
There was a problem hiding this comment.
Can we add more info about this breaking changes (what changes they have to make)?
jaeopt
requested changes
May 4, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Suggested a bit more details about ProjectConfigManager
CHANGELOG.md
Outdated
|
|
||
| ### Breaking Changes | ||
| - `OdpManager` in the SDK is enabled by default, if initialized using OptimizelyFactory. Unless an ODP account is integrated into the Optimizely projects, most `OdpManager` functions will be ignored. If needed, `OdpManager` to be disabled initialize `OptimizelyClient` without passing `OdpManager`. | ||
| - `ProjectConfigManager` interface additions + implementing class updates, which includes implementing `getCachedConfig()` and `getSDKKey()` methods. |
Contributor
There was a problem hiding this comment.
What about more details like -
ProjectConfigManager interface has been changed to add 2 more methods getCachedConfig() and getSDKKey(). Custom ProjectConfigManager should implement these new methods. See PollingProjectConfigManager for reference. This change is required to support ODPManager updated on datafile download (#501).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues