Skip to content

fix cppcheck warnings #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opsengine merged 1 commit into from
Feb 17, 2015
Merged

fix cppcheck warnings #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cpulimit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static void increase_priority() {

/* Get the number of CPUs */
static int get_ncpu() {
int ncpu = -1;
int ncpu;
#ifdef _SC_NPROCESSORS_ONLN
ncpu = sysconf(_SC_NPROCESSORS_ONLN);
#elif defined __APPLE__
Expand All @@ -156,6 +156,8 @@ static int get_ncpu() {
sysctl(mib, 2, &ncpu, &len, NULL, 0);
#elif defined _GNU_SOURCE
ncpu = get_nprocs();
#else
ncpu = -1;
#endif
return ncpu;
}
Expand Down
7 changes: 3 additions & 4 deletions src/list.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ void delete_node(struct list *l,struct list_node *node) {
}
l->count--;
free(node);
node = NULL;
}

void destroy_node(struct list *l,struct list_node *node) {
Expand All @@ -75,7 +74,7 @@ void destroy_node(struct list *l,struct list_node *node) {
delete_node(l,node);
}

int is_EMPTYLIST_list(struct list *l) {
int is_empty_list(struct list *l) {
return (l->count==0?TRUE:FALSE);
}

Expand Down Expand Up @@ -123,8 +122,8 @@ void *locate_elem(struct list *l,void *elem) {
}

void clear_list(struct list *l) {
struct list_node *tmp;
while(l->first!=EMPTYLIST) {
struct list_node *tmp;
tmp=l->first;
l->first=l->first->next;
free(tmp);
Expand All @@ -135,8 +134,8 @@ void clear_list(struct list *l) {
}

void destroy_list(struct list *l) {
struct list_node *tmp;
while(l->first!=EMPTYLIST) {
struct list_node *tmp;
tmp=l->first;
l->first=l->first->next;
free(tmp->data);
Expand Down
5 changes: 2 additions & 3 deletions src/memrchr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ memrchr(s, c, n)
int c;
size_t n;
{
const unsigned char *cp;

if (n != 0) {
cp = (unsigned char *)s + n;
const unsigned char *cp;
cp = (unsigned char *)s + n;
do {
if (*(--cp) == (unsigned char)c)
return((void *)cp);
Expand Down
4 changes: 2 additions & 2 deletions src/process_iterator_linux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

static int get_boot_time()
{
int uptime;
int uptime = 0;
FILE *fp = fopen ("/proc/uptime", "r");
if (fp != NULL)
{
Expand Down Expand Up @@ -103,7 +103,7 @@ static int read_process_info(pid_t pid, struct process *p)
return -1;
}
fclose(fd);
sscanf(buffer, "%s", p->command);
strcpy(p->command, buffer);
return 0;
}

Expand Down