Hide DiffSinger Language Code in Phoneme Canvas#1521
Merged
Conversation
Hide DiffSinger Language Code in Phoneme Canvas
…ixing mousehover mismatch with canvas
Collaborator
|
There is a bug: when two phoneme aliases are too close, when hovering or double clicking on the second phoneme, it's the first phoneme that reacts |
yqzhishen
reviewed
May 5, 2025
fix bug: when two phoneme aliases are too close, when hovering or double clicking on the second phoneme, it's the first phoneme that reacts
yqzhishen
approved these changes
May 6, 2025
oxygen-dioxide
approved these changes
May 15, 2025
lottev1991
pushed a commit
to lottev1991/OpenUtau
that referenced
this pull request
May 23, 2025
* Hide DiffSinger Language Code in Phoneme Canvas * move shared codes for phoneme UI rendering into PhonemeUIRender.cs, fixing mousehover mismatch with canvas * Update PhonemeUIRender.cs * Update PhonemeCanvas.cs --------- Co-authored-by: oxygen-dioxide <54425948+oxygen-dioxide@users.noreply.github.com> Co-authored-by: unknown <1463567152@qq.com>
maiko3tattun
pushed a commit
to maiko3tattun/OpenUtau
that referenced
this pull request
May 24, 2025
* Hide DiffSinger Language Code in Phoneme Canvas * move shared codes for phoneme UI rendering into PhonemeUIRender.cs, fixing mousehover mismatch with canvas * Update PhonemeUIRender.cs * Update PhonemeCanvas.cs --------- Co-authored-by: oxygen-dioxide <54425948+oxygen-dioxide@users.noreply.github.com> Co-authored-by: unknown <1463567152@qq.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will add the functionality to optionally obfuscate the DiffSinger language prefix in the phoneme editor. I have personally found this to be an annoyance while using Multi-Dictionary DiffSinger models. DiffSinger recently adopted Multi-Dictionary as the standard for voice library creation, and as such this issue will be present in all DiffSinger models.
This pull request does the following:
GetLangCode()function in all applicable DiffSinger phonemizers (G2p & Base) to be a public method instead of private, so it can be accessed inPhonemeCanvas.cs. This may cause incompatibilities with existing plugin phonemizers, but will not cause any issues with the built-in experience.PhonemeCanvas.cs, but only for the language prefix of the selected phonemizer (hence why I had to changeGetLangCode()to be a public method.)Example:
