Fixed many expression issues and improved the properties panel#1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development Background:
When lyrics or color changes reduced the number of phonemes in a note, old expressions that were no longer needed could cause bugs (e.g. Japanese phonemizer does not work well).
So I have improved that when right clicking on the UI to delete an expression, unwanted expressions with the same abbr in the same note are deleted.
Feature Improvements:
Fixes:
Note:
The default expressions for tracks have been implemented internally and are awaiting UI development.
In case the default values changed on a track-by-track in the future, I'm clearly separating the handling of cases where the default value is set and the value is null.