fix(xtest): detect java dpop support via supports subcommand#558
Conversation
The java-sdk removed the user-facing --dpop/--dpop-key CLI flags (opentdf/java-sdk#374); DPoP is now always-on and capability is exposed through the `supports` subcommand. The old detector grepped `help encrypt` for --dpop, which now finds nothing and marks java as not supporting dpop. Delegate to `cmdline.jar supports dpop` to match the existing dpop_nonce_challenge case. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the 'dpop' support check in the xtest/sdk/java/cli.sh script. It replaces a pipeline that grepped the help output of the encrypt command with a direct call to supports dpop on the Java command-line utility. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Java CLI script’s ChangesDPoP feature probing
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |



Problem
The java-sdk removed the user-facing
--dpop/--dpop-keyCLI flags in opentdf/java-sdk#374. DPoP is now always-on by default, and capability is exposed through thesupportssubcommand instead.The Java wrapper's
supports dpopcase still detects DPoP by greppinghelp encryptfor the--dpopflag:With the flags gone this grep finds nothing, exits 1, and xtest skips java DPoP tests:
The sibling
dpop_nonce_challengecase already delegates to thesupportssubcommand and is unaffected.Fix
Detect
dpopthe same waydpop_nonce_challengealready does — via thesupportssubcommand, whose exit code is the capability contract (0 = supported, 1 = not):set -o pipefailis dropped since there's no longer a pipe.Verification
With a current java
cmdline.jarinstalled:./cli.sh supports dpop; echo $?prints0, anddpop_nonce_challengestill returns0. Onlyxtest/sdk/java/cli.shchanges; other SDK wrappers are untouched.Summary by CodeRabbit