Skip to content

fix(sdk): add a test that has assertion statement values as objects#245

Merged
mkleene merged 11 commits into
mainfrom
add-test-with-object-assertions
Jan 29, 2025
Merged

fix(sdk): add a test that has assertion statement values as objects#245
mkleene merged 11 commits into
mainfrom
add-test-with-object-assertions

Conversation

@mkleene

@mkleene mkleene commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

Filewatcher sets assertion values as JSON objects like

"statement": {
  "format": "string",
  "value": {
    "context": {
      "@base": "urn:nato:stanag:5636:A:1:elements:json"
    },
    "ocl": {
      "catl": [
        {
          "name": "Releasable To",
          "type": "P",
          "vals": [
            "usa"
          ]
        }
      ],
      "pol": "2ccf11cb-6c9a-4e49-9746-a7f0a295945d",
      "cls": "SECRET",
      "dcr": "2024-12-17T13:00:52Z"
    }
  }

this adds a test that makes sure that all SDKs can properly deserialize such manifests when they
have assertion verification disabled.

In order to make this work we needed to pass through an option that disables assertion verification.

Requires opentdf/platform#1833 and opentdf/java-sdk#219 to be
merged before it will pass

successful run against SDK branches: https://github.com/opentdf/tests/actions/runs/12992325319/job/36231902231

@mkleene mkleene changed the title add a test that has assertion statement values as objects fix(sdk): add a test that has assertion statement values as objects Jan 27, 2025
@mkleene
mkleene marked this pull request as ready for review January 27, 2025 15:58
@mkleene
mkleene requested review from a team as code owners January 27, 2025 15:58
@sonarqubecloud

Copy link
Copy Markdown

@elizabethhealy elizabethhealy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a run with the java and go branches to verify the changes?

@mkleene

mkleene commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

can you do a run with the java and go branches to verify the changes?

It's in the comment

@mkleene
mkleene merged commit f3c156e into main Jan 29, 2025
@mkleene
mkleene deleted the add-test-with-object-assertions branch January 29, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants