Skip to content

fix(deps): bump moby/buildkit to v0.28.1 for govulncheck#3225

Merged
c-r33d merged 1 commit into
mainfrom
fix/bump-buildkit-tests-bdd
Mar 31, 2026
Merged

fix(deps): bump moby/buildkit to v0.28.1 for govulncheck#3225
c-r33d merged 1 commit into
mainfrom
fix/bump-buildkit-tests-bdd

Conversation

@dsm20

@dsm20 dsm20 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • go.work: go 1.25.0 → go 1.25.5 (required by buildkit v0.28.1)
  • tests-bdd/go.mod: go 1.25.0 → go 1.25.5, moby/buildkit v0.27.1 →
    v0.28.1, plus a handful of transitive dep bumps
  • this change is in response to a failing govluncheck

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain and refreshed project dependencies to the latest stable versions.

@dsm20
dsm20 requested review from a team as code owners March 30, 2026 20:07
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Go version and the moby/buildkit dependency. These changes were necessary to address a vulnerability identified by govulncheck and to ensure the project remains compatible with the latest version of buildkit.

Highlights

  • Dependency Update: Updated moby/buildkit to v0.28.1 to resolve a failing govulncheck scan.
  • Go Version Upgrade: Bumped the Go version to 1.25.5 in both go.work and tests-bdd/go.mod to satisfy the requirements of the new buildkit version.
  • Transitive Dependency Updates: Included several transitive dependency updates in tests-bdd/go.sum to ensure compatibility with the updated buildkit and Go version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


The build was failing, red and stark, We searched for bugs within the dark. A version bump, a simple fix, Now tests pass through the buildkit tricks.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai

coderabbitai Bot commented Mar 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bb780857-1600-4948-a456-c53e14c2924f

📥 Commits

Reviewing files that changed from the base of the PR and between 6590228 and 1e4a9ad.

⛔ Files ignored due to path filters (2)
  • go.work is excluded by !**/*.work
  • tests-bdd/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • tests-bdd/go.mod

📝 Walkthrough

Walkthrough

Updated the Go toolchain and several dependencies in tests-bdd/go.mod. The Go version target was bumped from 1.25.0 to 1.25.5. Multiple indirect dependencies were refreshed, including replacements for in-toto packages and version increments for compression, buildkit, and sigstore libraries.

Changes

Cohort / File(s) Summary
Go Module Dependencies
tests-bdd/go.mod
Updated Go toolchain target to 1.25.5; replaced github.com/in-toto/in-toto-golang v0.9.0 with github.com/in-toto/attestation v1.1.2; bumped in-toto-golang to v0.10.0, klauspost/compress to v1.18.4, moby/buildkit to v0.28.1, moby/patternmatcher to v0.6.1, secure-systems-lab/go-securesystemslib to v0.10.0, and sigstore/sigstore-go to stable v1.1.4.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Dependencies dance in harmony,
Version bumps flow so free,
Go 1.25 marches on with glee,
Sigstore and buildkit agree,
A modest hop through the dependency tree! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: bumping moby/buildkit to v0.28.1 to resolve a govulncheck issue, which is the primary motivation for all the dependency updates in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bump-buildkit-tests-bdd

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 197.346763ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 100.380199ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 391.519014ms
Throughput 255.42 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 41.560898092s
Average Latency 413.857904ms
Throughput 120.31 requests/second

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version to 1.25.5 across the workspace and bumps several dependencies in the tests-bdd module, including in-toto-golang, buildkit, and go-securesystemslib. Review feedback identifies that Go 1.25.5 is not a standard release version and will likely cause build failures. Additionally, the update to sigstore-go is flagged as a version downgrade from a pseudo-version to a tag, which requires correction or justification.

Comment thread go.work
Comment thread tests-bdd/go.mod
@github-actions

Copy link
Copy Markdown
Contributor

@c-r33d
c-r33d added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 99a8147 Mar 31, 2026
41 checks passed
@c-r33d
c-r33d deleted the fix/bump-buildkit-tests-bdd branch March 31, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants