feat(cli): add otdfctl to platform CI matrix#3221
Merged
Merged
Conversation
Add otdfctl to the checks.yaml go job matrix for govulncheck, golangci-lint, unit tests, and go fmt/tidy checks. DSPX-2658 Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
alkalescent
marked this pull request as ready for review
March 30, 2026 19:57
elizabethhealy
approved these changes
Mar 30, 2026
alkalescent
merged commit Mar 31, 2026
07bc639
into
DSPX-2655-migrate-otdfctl
33 of 34 checks passed
alkalescent
added a commit
that referenced
this pull request
Apr 6, 2026
### Proposed Changes * Add otdfctl to the checks.yaml go job matrix for govulncheck, golangci-lint, unit tests, and go fmt/tidy checks. ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
This was referenced Apr 6, 2026
alkalescent
added a commit
that referenced
this pull request
Apr 10, 2026
### Proposed Changes * Add otdfctl to the checks.yaml go job matrix for govulncheck, golangci-lint, unit tests, and go fmt/tidy checks. ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
alkalescent
added a commit
that referenced
this pull request
Apr 10, 2026
### Proposed Changes * Add otdfctl component to platform release-please configuration for independent versioned releases * Tags follow the monorepo per-component pattern: `otdfctl/v0.30.0` * Register `otdfctl/pkg/config/config.go` as extra-file so release-please bumps the `Version` constant (already has `// x-release-please-version` marker) * Create release workflow that triggers on `otdfctl/v*` tags, builds 8 cross-platform binaries (darwin amd64/arm64, linux amd64/arm/arm64, windows amd64/arm/arm64), and uploads artifacts to the GitHub release #### Files added/modified | File | Change | |------|--------| | `release-please-config.main.json` | Add `otdfctl` package entry with `extra-files` | | `release-please-manifest.json` | Add `"otdfctl": "0.30.0"` version tracking | | `release-please-config.otdfctl.json` | **New** — component config for `release/otdfctl/vX.Y` branches | | `release-otdfctl.yaml` | **New** — build and upload workflow on release publish | #### PR Stack (DSPX-2654) 1. #3205 — Subtree merge + module path rewrite (DSPX-2655, DSPX-2656) 2. #3208 — Makefile and build scripts (DSPX-2657) 3. #3221 — CI workflows (DSPX-2658) 4. #3236 — e2e tests and lint fixes (DSPX-2659) 5. **This PR** — Release pipeline (DSPX-2660) ### Checklist - [ ] I have added or updated unit tests - [x] I have added or updated integration tests (if appropriate) - [x] I have added or updated documentation ### Testing Instructions - Verify JSON configs are valid: `cat .github/release-please/release-please-config.main.json | jq .packages.otdfctl` - Verify manifest version: `cat .github/release-please/release-please-manifest.json | jq .otdfctl` - Verify `reusable_release-please.yaml` config lookup: branch `release/otdfctl/v0.30` → sanitized name `otdfctl` → resolves to `release-please-config.otdfctl.json` - Full release flow testable after merge by creating a manual release with tag `otdfctl/v0.30.0` --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
alkalescent
added a commit
that referenced
this pull request
Apr 14, 2026
### Proposed Changes * Add `otdfctl/e2e` to the `github-actions` dependabot ecosystem so composite action dependencies (`actions/setup-go`, `bats-core/bats-action`, `actions/upload-artifact`) are tracked * Add `otdfctl` gomod entry with daily schedule and `github.com/opentdf/*` internal dep exclusion, matching existing module patterns #### Files modified | File | Change | |------|--------| | `.github/dependabot.yml` | Add `otdfctl/e2e` to github-actions directories; add `otdfctl` gomod entry | #### Already configured (no changes needed) | Workflow | Status | |----------|--------| | Backport | Uses repo-wide reusable workflow | | CodeQL | Scans entire repo (no path filters) | | Dependency review | Single consolidated deny-license list | | PR lint | `cli` scope already present | | Checks matrix | `otdfctl` already in directory list | #### PR Stack (DSPX-2654) 1. #3205 — Subtree merge + module path rewrite (DSPX-2655, DSPX-2656) 2. #3208 — Makefile and build scripts (DSPX-2657) 3. #3221 — CI workflows (DSPX-2658) 4. #3236 — e2e tests and lint fixes (DSPX-2659) 5. #3268 — Release pipeline (DSPX-2660) 6. **This PR** — Supporting workflows (DSPX-2661) ### Checklist - [ ] I have added or updated unit tests - [x] I have added or updated integration tests (if appropriate) - [x] I have added or updated documentation ### Testing Instructions - Verify YAML is valid: `python3 -c "import yaml; yaml.safe_load(open('.github/dependabot.yml'))"` - Verify otdfctl gomod entry: search for `directory: "/otdfctl"` in dependabot.yml - Verify github-actions directories include `/otdfctl/e2e`
alkalescent
added a commit
that referenced
this pull request
Apr 20, 2026
### Proposed Changes * Add otdfctl to the checks.yaml go job matrix for govulncheck, golangci-lint, unit tests, and go fmt/tidy checks. ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
alkalescent
added a commit
that referenced
this pull request
Apr 20, 2026
* Add otdfctl component to platform release-please configuration for independent versioned releases * Tags follow the monorepo per-component pattern: `otdfctl/v0.30.0` * Register `otdfctl/pkg/config/config.go` as extra-file so release-please bumps the `Version` constant (already has `// x-release-please-version` marker) * Create release workflow that triggers on `otdfctl/v*` tags, builds 8 cross-platform binaries (darwin amd64/arm64, linux amd64/arm/arm64, windows amd64/arm/arm64), and uploads artifacts to the GitHub release | File | Change | |------|--------| | `release-please-config.main.json` | Add `otdfctl` package entry with `extra-files` | | `release-please-manifest.json` | Add `"otdfctl": "0.30.0"` version tracking | | `release-please-config.otdfctl.json` | **New** — component config for `release/otdfctl/vX.Y` branches | | `release-otdfctl.yaml` | **New** — build and upload workflow on release publish | 1. #3205 — Subtree merge + module path rewrite (DSPX-2655, DSPX-2656) 2. #3208 — Makefile and build scripts (DSPX-2657) 3. #3221 — CI workflows (DSPX-2658) 4. #3236 — e2e tests and lint fixes (DSPX-2659) 5. **This PR** — Release pipeline (DSPX-2660) - [ ] I have added or updated unit tests - [x] I have added or updated integration tests (if appropriate) - [x] I have added or updated documentation - Verify JSON configs are valid: `cat .github/release-please/release-please-config.main.json | jq .packages.otdfctl` - Verify manifest version: `cat .github/release-please/release-please-manifest.json | jq .otdfctl` - Verify `reusable_release-please.yaml` config lookup: branch `release/otdfctl/v0.30` → sanitized name `otdfctl` → resolves to `release-please-config.otdfctl.json` - Full release flow testable after merge by creating a manual release with tag `otdfctl/v0.30.0` --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
alkalescent
added a commit
that referenced
this pull request
Apr 20, 2026
### Proposed Changes * Add `otdfctl/e2e` to the `github-actions` dependabot ecosystem so composite action dependencies (`actions/setup-go`, `bats-core/bats-action`, `actions/upload-artifact`) are tracked * Add `otdfctl` gomod entry with daily schedule and `github.com/opentdf/*` internal dep exclusion, matching existing module patterns #### Files modified | File | Change | |------|--------| | `.github/dependabot.yml` | Add `otdfctl/e2e` to github-actions directories; add `otdfctl` gomod entry | #### Already configured (no changes needed) | Workflow | Status | |----------|--------| | Backport | Uses repo-wide reusable workflow | | CodeQL | Scans entire repo (no path filters) | | Dependency review | Single consolidated deny-license list | | PR lint | `cli` scope already present | | Checks matrix | `otdfctl` already in directory list | #### PR Stack (DSPX-2654) 1. #3205 — Subtree merge + module path rewrite (DSPX-2655, DSPX-2656) 2. #3208 — Makefile and build scripts (DSPX-2657) 3. #3221 — CI workflows (DSPX-2658) 4. #3236 — e2e tests and lint fixes (DSPX-2659) 5. #3268 — Release pipeline (DSPX-2660) 6. **This PR** — Supporting workflows (DSPX-2661) ### Checklist - [ ] I have added or updated unit tests - [x] I have added or updated integration tests (if appropriate) - [x] I have added or updated documentation ### Testing Instructions - Verify YAML is valid: `python3 -c "import yaml; yaml.safe_load(open('.github/dependabot.yml'))"` - Verify otdfctl gomod entry: search for `directory: "/otdfctl"` in dependabot.yml - Verify github-actions directories include `/otdfctl/e2e`
JBCongdon
pushed a commit
to JBCongdon/platform
that referenced
this pull request
May 24, 2026
### Proposed Changes * Base PR for the otdfctl migration stack ([DSPX-2654](https://virtru.atlassian.net/browse/DSPX-2654) epic) * Merge `opentdf/otdfctl` into `otdfctl/` via `git subtree add`, preserving full git history and tags * Rewrite Go module path and integrate with `go.work` workspace #### DSPX-2655: Subtree merge + cleanup - Subtree merge of latest otdfctl main (v0.30.0, includes namespace refactor and dependency bumps) - Remove files handled at platform root (`.github/`, `.golangci.yaml`, `CONTRIBUTING.md`, `LICENSE`) - Keep `otdfctl/CHANGELOG.md` for historical reference - Update root `.gitignore`, `CODEOWNERS`, pr-checks scope - Import tags as `otdfctl/*` prefix (e.g., `otdfctl/v0.26.2`) #### DSPX-2656: Module path rewrite - Rewrite module path: `github.com/opentdf/otdfctl` → `github.com/opentdf/platform/otdfctl` - Update all Go import statements (~54 files) - Add `otdfctl` to `go.work` workspace - Update `Dockerfile` #### DSPX-2657: Makefile and build scripts - Update root and otdfctl Makefiles for monorepo integration - Restore build scripts from original otdfctl repo #### DSPX-2658: CI matrix - Add otdfctl to `checks.yaml` go job matrix - govulncheck, golangci-lint, unit tests, go fmt/tidy checks #### PR Stack (DSPX-2654) 1. **This PR (opentdf#3205)** — Subtree merge + module path rewrite (DSPX-2655, DSPX-2656) 2. opentdf#3208 — Makefile and build scripts (DSPX-2657) 3. opentdf#3221 — CI workflows (DSPX-2658) 4. (future) — e2e tests (DSPX-2659) ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions - `git log --oneline --follow -M otdfctl/cmd/root.go` shows pre-merge history - `git tag | grep otdfctl/v0.26` confirms tags imported - `go build ./otdfctl/...` succeeds [DSPX-2654]: https://virtru.atlassian.net/browse/DSPX-2654?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Signed-off-by: Krish Suchak <suchak.krish@gmail.com> Co-authored-by: Chris Reed <87077975+c-r33d@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Testing Instructions