feat(authz): add casbin roleprovider interface#3069
Conversation
Summary of ChangesHello @elizabethhealy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the authorization system by introducing a flexible and extensible role provider mechanism for Casbin. It decouples role extraction logic from the core authorization engine, enabling developers to integrate custom methods for identifying user roles based on various sources, not just JWT claims. This change improves the modularity and adaptability of the authorization framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. A token flies, a claim is read, Roles are found, by logic led. Access granted, or denied with grace, Casbin's rules, in their proper place. Footnotes
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a RoleProvider interface to make role extraction for Casbin authorization pluggable. The changes are well-structured, introducing the new interface, a default implementation that maintains existing behavior, and configuration options to use it. I've found a few areas for improvement regarding Go idioms and error handling to increase code robustness and maintainability. My comments provide specific suggestions for these improvements.
X-Test Failure Report |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
X-Test Failure Reportopentdf |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
/gemini summary |
|
/gemini review |
Summary of ChangesThis pull request significantly enhances the authorization system by introducing a flexible and extensible role provider mechanism for Casbin. It decouples the logic for extracting user roles from the core authorization engine, allowing for custom implementations beyond just JWT claims. This change improves the modularity and adaptability of the authorization framework, making it easier to integrate diverse role identification methods and configure them programmatically or declaratively. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
There was a problem hiding this comment.
Code Review
This pull request introduces a flexible and extensible role provider mechanism for Casbin, which is a great enhancement for modularity and adaptability. The code is well-structured, with the new authz.RoleProvider interface and related components clearly defined in the new service/pkg/authz/role_provider.go file. The refactoring to move JWT claim extraction logic into its own jwtClaimsRoleProvider is a clean separation of concerns. The changes are also accompanied by relevant tests. I have a couple of suggestions to improve warning and error messages for configuration issues, which should enhance the developer experience when using this new feature.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
X-Test Failure Reportopentdf |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
🤖 I have created a release *beep* *boop* --- ## [0.13.0](service/v0.12.0...service/v0.13.0) (2026-02-18) ### ⚠ BREAKING CHANGES * **policy:** remove namespace certificate feature ([#3051](#3051)) ### Features * **authz:** add casbin roleprovider interface ([#3069](#3069)) ([9d6b3f3](9d6b3f3)) * **core:** add interceptors to start options ([#3031](#3031)) ([e0b4e93](e0b4e93)) ### Bug Fixes * **deps:** bump github.com/opentdf/platform/lib/fixtures from 0.4.0 to 0.5.0 in /service ([#3034](#3034)) ([66b61b1](66b61b1)) * **deps:** bump github.com/opentdf/platform/lib/ocrypto from 0.9.0 to 0.10.0 in /service ([#3080](#3080)) ([49582f0](49582f0)) * **deps:** bump github.com/opentdf/platform/protocol/go from 0.15.0 to 0.16.0 in /service ([#3083](#3083)) ([a332f95](a332f95)) * **deps:** vulnerability fix in connect-rpc validate and ristretto ([#3065](#3065)) ([8860fed](8860fed)) * Go 1.25 ([#3053](#3053)) ([65eb7c3](65eb7c3)) * **kas:** dont hardcode P-256 curve ([#3073](#3073)) ([826d857](826d857)) * **kas:** Fix EC P-521 typo ([#3075](#3075)) ([abc088d](abc088d)) * **policy:** reject unencrypted private keys for modes 1/2 ([#3072](#3072)) ([e2dc6d8](e2dc6d8)) ### Code Refactoring * **policy:** remove namespace certificate feature ([#3051](#3051)) ([48abb81](48abb81)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Summary of Changes
This pull request introduces a flexible and extensible role provider mechanism for Casbin. It decouples the logic for extracting user roles from the core authorization engine, allowing for custom implementations beyond just JWT claims. This change improves the modularity and adaptability of the authorization framework, making it easier to integrate diverse role identification methods and configure them programmatically or declaratively.
Highlights
Checklist
Testing Instructions