ROSAENG-61053 | chore: bump Go to 1.26.3#3321
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates Go version references in module files, Dockerfiles, and Renovate config, and removes one Renovate package rule. It also refactors command and helper code to use Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
Hi @olucasfreitas this might be a good opportunity to also run the go fix command wdyt |
|
@amandahla agreed, will do it here and ping you again |
|
@amandahla added in I ran
I left the PR as draft until the paired release PR lands and Prow can pick up the Go 1.26 builder. |
8629526 to
9e73470
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/create/idp/cmd.go`:
- Around line 447-461: The IDP validation messages in ValidateIdpName and
getMappingMethod no longer match the existing e2e assertions, so align the
returned error strings with the expected wording. Update the cluster-admin
reserve message in ValidateIdpName and the mapping method validation message in
getMappingMethod to use the same capitalization and punctuation as the tests, or
adjust the corresponding e2e assertions to match the new strings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: c734004f-91cb-47af-a877-4371e66bae88
📒 Files selected for processing (19)
cmd/create/iamserviceaccount/cmd.gocmd/create/idp/cmd.gocmd/create/idp/htpasswd.gocmd/edit/ingress/flags.gocmd/list/accessrequests/cmd.gocmd/list/imagemirrors/cmd.gocmd/list/imagemirrors/cmd_test.gopkg/fedramp/config.gopkg/helper/url/helpers.gopkg/iamserviceaccount/helpers.gopkg/input/helper.gopkg/kubeletconfig/output.gopkg/logforwarding/helpers.gopkg/logforwarding/output.gopkg/logging/aws_logger.gopkg/logging/round_tripper.gopkg/network/helper.gopkg/output/reporter.gopkg/reporter/reporter.go
✅ Files skipped from review due to trivial changes (5)
- pkg/logforwarding/output.go
- cmd/list/imagemirrors/cmd_test.go
- cmd/create/idp/htpasswd.go
- pkg/logging/round_tripper.go
- cmd/create/iamserviceaccount/cmd.go
|
@amandahla ready for review |
|
@olucasfreitas please check the failures, you are facing same error that I got in my PR, 1.26.4 is not available in all images. |
openshift-ci
Bot
added
the
needs-rebase
olucasfreitas
changed the title
Update the ROSA CLI toolchain from Go 1.25.8 to Go 1.26.4 across go.mod, Dockerfiles, and Renovate configuration. Remove the k8s.io/apimachinery < 0.36.0 version pin that was only necessary while the repo was on Go 1.25. Run go fix as part of the Go 1.26 upgrade and keep the verified subset of mechanical updates that passes the repo's format, lint, changed-lines coverage, and unit/integration test gates. Paired with: openshift/release#81358
Follow the 1.26.3 rollout pattern used in terraform-provider-rhcs and move the ROSA repo off 1.26.4, which is not available in all required images yet. Align go.mod, Dockerfiles, Renovate, and the committed bingo tool modules to the 1.26.3 baseline.
aee8afd to
23ac5e9
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
@amandahla updated to the This branch now:
Local |
|
/test lint |
|
/override ci/prow/security |
|
@olucasfreitas: Overrode contexts on behalf of olucasfreitas: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3321 +/- ##
==========================================
+ Coverage 28.03% 28.08% +0.04%
==========================================
Files 334 334
Lines 36710 36730 +20
==========================================
+ Hits 10293 10316 +23
+ Misses 25663 25660 -3
Partials 754 754 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…trings The go fix cleanup lowercased validation messages in cmd/create/idp/cmd.go but the e2e tests still asserted the old capitalized wording. Update the two assertions in test_rosacli_idp.go to match.
|
/override ci/prow/security |
|
@amandahla @jerichokeyne ready for review when you can |
|
@olucasfreitas: Overrode contexts on behalf of olucasfreitas: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/security |
|
@olucasfreitas: Overrode contexts on behalf of olucasfreitas: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
/test ci/prow/security |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, olucasfreitas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test security |
|
/retest-required |
|
/test security |
|
/retest-required |
37982ff
into
openshift:master
|
@olucasfreitas: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
go.mod, all Dockerfiles, Renovate config, and the committed Bingo tool modulesgo fix ./...mechanical cleanup that already passes the repo's local gates on this branchDetailed Description of the Issue
The repository baseline was Go 1.25.8. Upstream dependency bumps (ginkgo, gomega, kubernetes) will soon require Go 1.26+, so the toolchain needs to advance. Go 1.26.4 was initially targeted but the
ocp_builderimages only carry 1.26.3 at this time, so we follow the proven 1.26.3 pattern from terraform-redhat/terraform-provider-rhcs#1240.Type of Change
Previous Behavior
go.moddeclared Go 1.25.8ubi9/go-toolset:1.25.8k8s.io/apimachinery < 0.36.0Behavior After This Change
go.moddeclares Go 1.26.3ubi9/go-toolset:1.26.3go fixmechanical cleanup applied (interface{} -> any, strings.Builder, etc.)Breaking Changes
Test plan
GOTOOLCHAIN=go1.26.3 go mod tidyGOTOOLCHAIN=go1.26.3 go mod downloadGOTOOLCHAIN=go1.26.3 go mod verifyGOTOOLCHAIN=go1.26.3 go fix ./...make generatemake pre-push-checksRelated