OCM-00000 | chore: bump hashicorp/go-version to v1.9.0

[amandahla]

Summary

• Bump github.com/hashicorp/go-version from v1.6.0 to v1.9.0 with vendored updates.
• Update four unit test assertions to match lowercase malformed version: error text in go-version v1.9.0.
• Supersedes Renovate PR OCM-00000 | ci: Update module github.com/hashicorp/go-version to v1.9.0 #3288, which we cannot push fixes to.

Test plan

• go test ./pkg/ocm/... ./pkg/helper/versions/...
• make test

Related

• Supersedes: OCM-00000 | ci: Update module github.com/hashicorp/go-version to v1.9.0 #3288
• Jira: OCM-00000 (placeholder — update with real ticket if required)

Made with Cursor

Summary by CodeRabbit

• Bug Fixes

  • Standardized malformed version error messages to use consistent lowercase wording (for inputs that can’t be parsed).

• Chores

  • Updated the version-handling dependency to a newer release.

• Tests

  • Updated automated test expectations to match the revised malformed-version error text.

[coderabbitai]

Warning

Review limit reached

@amandahla, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eb81d70a-1c0d-453d-b2d2-4c0c149dedea

📥 Commits

Reviewing files that changed from the base of the PR and between b7a746e and aaa5e3b.

⛔ Files ignored due to path filters (8)

• go.sum is excluded by !**/*.sum
• vendor/github.com/hashicorp/go-version/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/hashicorp/go-version/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/hashicorp/go-version/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/hashicorp/go-version/constraint.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/hashicorp/go-version/version.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/hashicorp/go-version/version_collection.go is excluded by !vendor/**, !**/vendor/**
• vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (4)

• go.mod
• pkg/helper/versions/helpers_test.go
• pkg/ocm/helpers_test.go
• pkg/ocm/versions_test.go

📝 Walkthrough

Walkthrough

Updated go.mod to use github.com/hashicorp/go-version v1.9.0. Updated version-related tests in helper and ocm packages to expect lowercase malformed version: ... error messages for invalid inputs.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers summary, tests, and related links, but it omits most template sections like issue context, behavior change, and verification details.	Add the missing template sections: problem/context, previous vs. new behavior, type of change, step-by-step testing, proof, breaking changes, and verification checklist items.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately states the main change: bumping hashicorp/go-version to v1.9.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes error-message assertions; the touched Ginkgo titles are static strings and show no dynamic name construction.
Test Structure And Quality	✅ Passed	Touched specs only update expected error text; they remain single-purpose, use existing setup/cleanup patterns, and add no waits or resource lifecycle issues.
Microshift Test Compatibility	✅ Passed	Diff only updates go-version vendor files and three existing unit-test expectations; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only changes go.mod and unit-test error-string expectations; no new Ginkgo e2e tests or multi-node/SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only bumps go-version and updates unit-test error strings; no deployment manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	Only dependency and test-string changes; no stdout writes were added in any main/init/TestMain/BeforeSuite/RunSpecs path, and vendored go-version has no stdout side effects.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new e2e tests were added; the touched Ginkgo specs are unit tests with fake/local servers and no public connectivity.
No-Weak-Crypto	✅ Passed	Touched files only bump go-version and tweak error-string tests; no MD5/SHA1/DES/RC4/3DES/custom crypto or secret comparisons found.
Container-Privileges	✅ Passed	PR updates deps/tests only; manifest-like files scanned had no privileged, host*, allowPrivilegeEscalation, or SYS_ADMIN settings.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files only bump go-version and adjust test error strings; no new logging or sensitive-data exposure was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@amandahla: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test	6060792	link	true	/test test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.17%. Comparing base (13c2449) to head (aaa5e3b).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3294   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files         334      334           
  Lines       36704    36704           
=======================================
  Hits         9608     9608           
  Misses      26359    26359           
  Partials      737      737           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[olucasfreitas]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [amandahla,olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment