OCM-00000 | ci: Update module github.com/alessio/shellescape to v1.6.0#3286
OCM-00000 | ci: Update module github.com/alessio/shellescape to v1.6.0#3286red-hat-konflux[bot] wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates the 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9f60c5c to
985d2f8
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 72: Update the shellescape dependency to the new module path consistently
across the repo. In go.mod, replace the old github.com/alessio/shellescape entry
with al.essio.dev/pkg/shellescape, and make sure
pkg/clusterregistryconfig/flags.go imports the new path as well. Also remove or
update the stale indirect reference in .bingo/goreleaser.mod so all references
to shellescape use the same module path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8a78b04f-02ec-4709-90fa-a20fa1948098
📒 Files selected for processing (1)
go.mod
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect | ||
| github.com/99designs/keyring v1.2.2 // indirect | ||
| github.com/alessio/shellescape v1.4.1 | ||
| github.com/alessio/shellescape v1.6.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find every shellescape reference so the module-path update can be made consistently.
rg -n --hidden --glob '!**/vendor/**' \
'github.com/alessio/shellescape|al\.essio\.dev/pkg/shellescape' .Repository: openshift/rosa
Length of output: 1094
Switch this dependency to the new module path. v1.6.0 declares al.essio.dev/pkg/shellescape, but pkg/clusterregistryconfig/flags.go still imports github.com/alessio/shellescape (and .bingo/goreleaser.mod still carries the old indirect entry), so this bump needs to be updated consistently.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 72, Update the shellescape dependency to the new module path
consistently across the repo. In go.mod, replace the old
github.com/alessio/shellescape entry with al.essio.dev/pkg/shellescape, and make
sure pkg/clusterregistryconfig/flags.go imports the new path as well. Also
remove or update the stale indirect reference in .bingo/goreleaser.mod so all
references to shellescape use the same module path.
Source: MCP tools
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
985d2f8 to
751923c
Compare
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v1.4.1→v1.6.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
alessio/shellescape (github.com/alessio/shellescape)
v1.6.0Compare Source
What's Changed
New Contributors
Full Changelog: alessio/shellescape@v1.5.1...v1.6.0
v1.5.1Compare Source
Changelog
aaff7ceupdate readme to use the new vanity nameeee5f61update playground example's URLv1.5.0Compare Source
Changelog
312088dCreate sonarqube.yml823e979add testable example (#24)27a48e3fail fast on errorsbb4dcb3fix imports4f9bf6bfix imports (#26)1b4bdc1new testable examplea6eeed4remove sonarqube config filea5719a4update build config6d0d828update gitignorea792e00update gitignore, add Makefile62618b3update go.mod and go.sumv1.4.2Compare Source
What's Changed
Full Changelog: alessio/shellescape@v1.4.1...v1.4.2
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.