Skip to content

OCM-00000 | ci: Update module github.com/alessio/shellescape to v1.6.0#3286

Closed
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-alessio-shellescape-1.x
Closed

OCM-00000 | ci: Update module github.com/alessio/shellescape to v1.6.0#3286
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-alessio-shellescape-1.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/alessio/shellescape v1.4.1v1.6.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

alessio/shellescape (github.com/alessio/shellescape)

v1.6.0

Compare Source

What's Changed

New Contributors

Full Changelog: alessio/shellescape@v1.5.1...v1.6.0

v1.5.1

Compare Source

Changelog

  • Fixes for #​28
    • aaff7ce update readme to use the new vanity name
    • eee5f61 update playground example's URL

v1.5.0

Compare Source

Changelog

v1.4.2

Compare Source

What's Changed

Full Changelog: alessio/shellescape@v1.4.1...v1.4.2


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b5d9affd-cc7a-4ac4-8440-b85d27c894ac

📥 Commits

Reviewing files that changed from the base of the PR and between 985d2f8 and 751923c.

📒 Files selected for processing (1)
  • go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

The PR updates the github.com/alessio/shellescape dependency in go.mod from v1.4.1 to v1.6.0.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly a Renovate update log and lacks the repository's required template sections and validation details. Fill in the template sections: PR Summary, issue context, related issues, change type, test steps/results, proof, and checklist items.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency update and version bump, matching the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes go.mod; no *_test.go files were modified, so there are no Ginkgo titles to inspect for unstable names.
Test Structure And Quality ✅ Passed PR only bumps go.mod shellescape version; no Ginkgo test files or test logic were changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No changed test-like files or tests/e2e files were present in the PR diff; this is a dependency/vendor update only.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only go.mod changed for a shellescape version bump; no Ginkgo/e2e tests were added or modified, so SNO compatibility is unaffected.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod changed for a shellescape version bump; no deployment, controller, or scheduling-related code was modified.
Ote Binary Stdout Contract ✅ Passed PR only changes go.mod to bump shellescape; no process-level code or stdout writes were modified, so the stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Not applicable: this PR only updates go.mod to bump shellescape; no new Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto ✅ Passed PR only bumps github.com/alessio/shellescape in go.mod; no weak-crypto APIs or custom crypto code were added.
Container-Privileges ✅ Passed Dependency-only go.mod bump; no tracked manifests contain privileged/root/host* settings or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed PR only bumps shellescape in go.mod; no source/logging files changed and worktree is clean.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-alessio-shellescape-1.x

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign robpblake for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-alessio-shellescape-1.x branch from 9f60c5c to 985d2f8 Compare June 25, 2026 22:42
@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -t ./...
go: github.com/alessio/shellescape@v1.6.0: parsing go.mod:
	module declares its path as: al.essio.dev/pkg/shellescape
	        but was required as: github.com/alessio/shellescape

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 72: Update the shellescape dependency to the new module path consistently
across the repo. In go.mod, replace the old github.com/alessio/shellescape entry
with al.essio.dev/pkg/shellescape, and make sure
pkg/clusterregistryconfig/flags.go imports the new path as well. Also remove or
update the stale indirect reference in .bingo/goreleaser.mod so all references
to shellescape use the same module path.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8a78b04f-02ec-4709-90fa-a20fa1948098

📥 Commits

Reviewing files that changed from the base of the PR and between 729b707 and 985d2f8.

📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
github.com/99designs/keyring v1.2.2 // indirect
github.com/alessio/shellescape v1.4.1
github.com/alessio/shellescape v1.6.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find every shellescape reference so the module-path update can be made consistently.
rg -n --hidden --glob '!**/vendor/**' \
  'github.com/alessio/shellescape|al\.essio\.dev/pkg/shellescape' .

Repository: openshift/rosa

Length of output: 1094


Switch this dependency to the new module path. v1.6.0 declares al.essio.dev/pkg/shellescape, but pkg/clusterregistryconfig/flags.go still imports github.com/alessio/shellescape (and .bingo/goreleaser.mod still carries the old indirect entry), so this bump needs to be updated consistently.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 72, Update the shellescape dependency to the new module path
consistently across the repo. In go.mod, replace the old
github.com/alessio/shellescape entry with al.essio.dev/pkg/shellescape, and make
sure pkg/clusterregistryconfig/flags.go imports the new path as well. Also
remove or update the stale indirect reference in .bingo/goreleaser.mod so all
references to shellescape use the same module path.

Source: MCP tools

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-alessio-shellescape-1.x branch from 985d2f8 to 751923c Compare June 30, 2026 21:27
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 751923c link true /test lint
ci/prow/security 751923c link false /test security
ci/prow/test 751923c link true /test test
ci/prow/images-images 751923c link true /test images-images
ci/prow/build 751923c link true /test build
ci/prow/e2e-presubmits-images 751923c link true /test e2e-presubmits-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v1.6.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/github.com-alessio-shellescape-1.x branch July 1, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant