Skip to content

openshift/os: release-4.22: fix FROM replacement - #82583

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustymabe:dusty-fix-extensions-4.22
Jul 28, 2026
Merged

openshift/os: release-4.22: fix FROM replacement#82583
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustymabe:dusty-fix-extensions-4.22

Conversation

@dustymabe

@dustymabe dustymabe commented Jul 28, 2026

Copy link
Copy Markdown
Member

The one for the extensions build should be ${IMAGE_FROM} now.

Fixes e2baca5

Summary by CodeRabbit

  • Updates the OpenShift 4.22 OS release CI configuration to use the ${IMAGE_FROM} parameter for the rhel-coreos-extensions build base image, replacing the hard-coded rhel-coreos:latest reference.
  • Makes the extensions build source image configurable through the CI build environment.

The one for the extensions build should be `${IMAGE_FROM}` now.

Fixes e2baca5
@dustymabe

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d01229d5-af2a-4d79-9de2-6f1c07a44227

📥 Commits

Reviewing files that changed from the base of the PR and between 94b33b7 and fd1ebfa.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/os/openshift-os-release-4.22.yaml

Walkthrough

The 4.22 rhel-coreos-extensions image build now sources its rhel-coreos input from ${IMAGE_FROM} instead of a fixed latest image reference.

Changes

CoreOS source image configuration

Layer / File(s) Summary
Parameterize CoreOS input
ci-operator/config/openshift/os/openshift-os-release-4.22.yaml
The rhel-coreos input now uses ${IMAGE_FROM} rather than the hard-coded CI latest tag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: aaradhak

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the release-4.22 FROM replacement change in openshift/os.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CI YAML input changed; no Ginkgo test titles or test files were added or modified.
Test Structure And Quality ✅ Passed PR only changes a ci-operator YAML input reference; no Ginkgo test code or cluster-interacting tests are added or modified.
Microshift Test Compatibility ✅ Passed Only a YAML image reference changed; no new or modified Ginkgo tests or MicroShift-relevant APIs were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only changes a ci-operator YAML config; no Ginkgo test files or new e2e tests were added.
Topology-Aware Scheduling Compatibility ✅ Passed The only change is a CI image input swap to ${IMAGE_FROM}; no scheduling, replicas, affinity, nodeSelector, or topology fields are added.
Ote Binary Stdout Contract ✅ Passed PR only changes a ci-operator YAML image input; no OTE binary process code or stdout writes are touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a CI YAML image input changed; no Ginkgo test code or new It/Describe/Context/When blocks were added.
No-Weak-Crypto ✅ Passed PASS: The PR only updates a YAML image reference to ${IMAGE_FROM}; the file contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or crypto logic.
Container-Privileges ✅ Passed The only changed file is a ci-operator image input ref; no container/K8s manifests or privilege settings are present.
No-Sensitive-Data-In-Logs ✅ Passed Only a CI YAML image input changed to ${IMAGE_FROM}; no logging code or sensitive data exposure was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustymabe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-release-4.22-e2e-aws openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.22-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.22-okd-scos-e2e-aws-ovn openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.22-okd-scos-images openshift/os presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aaradhak aaradhak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2026
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7ef5126 into openshift:main Jul 28, 2026
14 checks passed
enxebre pushed a commit to enxebre/release that referenced this pull request Jul 29, 2026
The one for the extensions build should be `${IMAGE_FROM}` now.

Fixes e2baca5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants