ACM-35633: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.21 by amitesh1201 · Pull Request #82390 · openshift/release

amitesh1201 · 2026-07-24T09:23:40Z

Summary

Update build_root and dockerfile_literal Go toolchain from rhel-9-release-golang-1.24-openshift-4.21 to rhel-9-release-golang-1.25-openshift-4.22 for cluster-api-provider-kubevirt release-4.21 CI config.
Required because CAPK release-4.21 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829 + related CVEs), which requires Go 1.25.0.
Jira: ACM-35633 (MCE 2.11 / OCP 4.21)

Why

Without this change, CI jobs for the CAPK release-4.21 crypto bump fail with:

go: go.mod requires go >= 1.25.0 (running go 1.24.x; GOTOOLCHAIN=local)

Same pattern as the merged release-4.20 change: #82010

Changes

Location	Before	After
`build_root.image_stream_tag.tag`	`rhel-9-release-golang-1.24-openshift-4.21`	`rhel-9-release-golang-1.25-openshift-4.22`
`dockerfile_literal` FROM	`...golang-1.24-openshift-4.21`	`...golang-1.25-openshift-4.22`

Test plan

CI config validation jobs pass on this PR
After merge, CAPK release-4.21 crypto bump PR can build with Go 1.25

Summary by CodeRabbit

Updates the cluster-api-provider-kubevirt release-4.21 CI image configuration to use Go 1.25 on OpenShift 4.22 for image builds, enabling the upcoming golang.org/x/crypto security update requiring Go 1.25.

…ubevirt release-4.21 Update build_root and dockerfile_literal to use rhel-9-release-golang-1.25-openshift-4.22 (from golang-1.24-openshift-4.21). Required because CAPK release-4.21 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829), which requires Go 1.25.0.

openshift-ci-robot · 2026-07-24T09:23:44Z

@amitesh1201: This pull request references ACM-35633 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "MCE 2.11.0" instead.

Details

In response to this:

Summary

Update build_root and dockerfile_literal Go toolchain from rhel-9-release-golang-1.24-openshift-4.21 to rhel-9-release-golang-1.25-openshift-4.22 for cluster-api-provider-kubevirt release-4.21 CI config.

Required because CAPK release-4.21 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829 + related CVEs), which requires Go 1.25.0.

Jira: ACM-35633 (MCE 2.11 / OCP 4.21)

Why

Without this change, CI jobs for the CAPK release-4.21 crypto bump fail with:
go: go.mod requires go >= 1.25.0 (running go 1.24.x; GOTOOLCHAIN=local)
Same pattern as the merged release-4.20 change: #82010

Changes

Location Before After

build_root.image_stream_tag.tag rhel-9-release-golang-1.24-openshift-4.21 rhel-9-release-golang-1.25-openshift-4.22

dockerfile_literal FROM ...golang-1.24-openshift-4.21 ...golang-1.25-openshift-4.22

Test plan

CI config validation jobs pass on this PR

After merge, CAPK release-4.21 crypto bump PR can build with Go 1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-24T09:25:43Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fc9d22e7-33cf-4bb2-b325-505f632c3d60

📥 Commits

Reviewing files that changed from the base of the PR and between 86e024c and fc31a1a.

📒 Files selected for processing (1)

ci-operator/config/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-release-4.21.yaml

Walkthrough

The release configuration updates the image build toolchain from the Go 1.24/OpenShift 4.21 release image to the Go 1.25/OpenShift 4.22 release image.

Changes

Toolchain Image Update

Layer / File(s)	Summary
Update toolchain image reference `ci-operator/config/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-release-4.21.yaml`	The toolchain stage and matching tag now reference the Go 1.25/OpenShift 4.22 release image.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

openshift/release#81264: Updates a related OpenShift CI toolchain image reference.

Suggested labels: lgtm, approved, rehearsals-ack

Suggested reviewers: orenc1

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: bumping CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.21.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a CI config YAML changed; no Ginkgo test titles or test files were added or edited.
Test Structure And Quality	✅ Passed	PR only changes a ci-operator YAML config file; no Ginkgo test files or test code were modified.
Microshift Test Compatibility	✅ Passed	Only a CI config YAML changed; no new Ginkgo tests or MicroShift-sensitive API usage were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates CI image references in a YAML config; no new Ginkgo e2e tests or SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI image/toolchain refs changed in a YAML config; no deployment manifests or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	Only CI YAML changed; no process-level code or stdout writes were added, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CI config image tags changed; no new Ginkgo/e2e tests or network code were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	PR only updates CI Go image tags; the edited YAML contains no weak-crypto algorithms, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	Only Go toolchain image tags changed; no privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation/SYS_ADMIN/root settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Only Go toolchain image tags changed in a CI config YAML; no new logging or sensitive data appears in the diff.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-07-24T09:26:41Z

[REHEARSALNOTIFIER]
@amitesh1201: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-e2e-hypershift-kubevirt	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-images	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-unit-tests	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

amitesh1201 · 2026-07-24T10:16:50Z

/pj-rehearse pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-e2e-hypershift-kubevirt pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-images pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-unit-tests

openshift-merge-bot · 2026-07-24T10:16:54Z

@amitesh1201: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-07-24T16:42:11Z

@amitesh1201: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt	`fc31a1a`	link	unknown	`/pj-rehearse pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-e2e-hypershift-kubevirt`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

amitesh1201 · 2026-07-24T19:10:47Z

/retest

amitesh1201 · 2026-07-25T12:47:40Z

/pj-rehearsh ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt

amitesh1201 · 2026-07-25T13:00:23Z

/pj-rehearse ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt

openshift-merge-bot · 2026-07-25T13:00:26Z

@amitesh1201: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-25T13:03:29Z

@amitesh1201: job(s): ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt either don't exist or were not found to be affected, and cannot be rehearsed

amitesh1201 · 2026-07-27T08:38:38Z

The e2e-hypershift-kubevirt rehearsal has been retried 2–3 times and consistently hits the 5-hour Prow job timeout during the post/gather phase — not due to any actual test failure.

Evidence from the latest run:

All build steps succeeded (Go 1.25 image built correctly)
All e2e test steps passed (run-e2e-local: 55m, run-e2e-external: 1h20m)
Job was interrupted at exactly the 5h mark during gather-aws-console (a cleanup/artifact-collection step)
Final reason: executing_graph:interrupted — not a test assertion failure

This looks like an infra timing issue with the e2e-hypershift-kubevirt job. The actual code change (bumping build_root and dockerfile_literal from Go 1.24/OCP 4.21 to Go 1.25/OCP 4.22) is validated: builds and tests pass.

Requesting /pj-rehearse ack and lgtm to unblock this PR.

/cc @damdo @nunnatsa — could you please review and approve?

damdo

/lgtm

/assign @nunnatsa

nunnatsa

/approve
/lgtm

openshift-ci · 2026-07-30T05:28:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitesh1201, damdo, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/cluster-api-provider-kubevirt/OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nunnatsa · 2026-07-30T05:28:24Z

/pj-rehearse ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt

openshift-merge-bot · 2026-07-30T05:28:27Z

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-30T05:31:24Z

@nunnatsa: job(s): ci/rehearse/openshift/cluster-api-provider-kubevirt/release-4.21/e2e-hypershift-kubevirt either don't exist or were not found to be affected, and cannot be rehearsed

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026

openshift-ci Bot requested review from nirarg and qinqon July 24, 2026 09:23

amitesh1201 mentioned this pull request Jul 24, 2026

ACM-35633: Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39829 openshift/cluster-api-provider-kubevirt#499

Open

This was referenced Jul 24, 2026

ACM-36515: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.19 #82431

Open

ACM-36505: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.18 #82432

Open

damdo reviewed Jul 27, 2026

View reviewed changes

openshift-ci Bot assigned nunnatsa and damdo Jul 27, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2026

nunnatsa approved these changes Jul 30, 2026

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026

Uh oh!

Conversation

amitesh1201 commented Jul 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Changes

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 24, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Changes

Test plan

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

amitesh1201 commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

amitesh1201 commented Jul 24, 2026

Uh oh!

amitesh1201 commented Jul 25, 2026

Uh oh!

amitesh1201 commented Jul 25, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 25, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 25, 2026

Uh oh!

amitesh1201 commented Jul 27, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

nunnatsa left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 30, 2026

Uh oh!

nunnatsa commented Jul 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amitesh1201 commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 24, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading