Use Go 1.25 builder for OSC devel CI - #81887
Conversation
Go 1.26 (set in openshift#81818 and corrected in openshift#81857) causes go mod tidy failures because it bumps major k8s dependencies (api/apimachinery from v0.34 to v0.35, controller-runtime from v0.22 to v0.23) which is unsafe on the release branch. Use rhel-9-golang-1.25-openshift-4.22 instead, which provides Go 1.25.x compatible with go.mod's "go 1.25.7" directive and avoids any dependency churn. Signed-off-by: Daniel Kreling <dkreling@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe devel OpenShift CI configuration now uses the ChangesCI Builder Image
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
A total of 61 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dbkreling, vvoronko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@dbkreling: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@dbkreling: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Go 1.26 (set in openshift#81818 and corrected in openshift#81857) causes go mod tidy failures because it bumps major k8s dependencies (api/apimachinery from v0.34 to v0.35, controller-runtime from v0.22 to v0.23) which is unsafe on the release branch. Use rhel-9-golang-1.25-openshift-4.22 instead, which provides Go 1.25.x compatible with go.mod's "go 1.25.7" directive and avoids any dependency churn. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
Go 1.26 (set in #81818 and corrected in #81857) causes go mod tidy failures because it bumps major k8s dependencies (api/apimachinery from v0.34 to v0.35, controller-runtime from v0.22 to v0.23) which is unsafe on the release branch.
Use rhel-9-golang-1.25-openshift-4.22 instead, which provides Go 1.25.x compatible with go.mod's "go 1.25.7" directive and avoids any dependency churn.
Summary by CodeRabbit
go mod tidyfrom upgrading Kubernetes dependencies while remaining compatible with the project’s Go 1.25.7 directive.