Skip to content

[ospdo] Pass GOLANG_BASE for Go 1.26 CI build root image#81527

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stuggi:ospdo-golang-1.26-fix
Jul 7, 2026
Merged

[ospdo] Pass GOLANG_BASE for Go 1.26 CI build root image#81527
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stuggi:ospdo-golang-1.26-fix

Conversation

@stuggi

@stuggi stuggi commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The ci-build-root-golang-1.26-sdk-1.42.3 image was being built without overriding GOLANG_BASE, so it defaulted to Go 1.24 from the Dockerfile. Pass the Go 1.26 base image explicitly.

Jira: OSPRH-32127

Summary by CodeRabbit

Updated the OpenStack K8s Operators CI build-root image configuration so the Go 1.26 SDK image is explicitly used as the base. This fixes the ci-build-root-golang-1.26-sdk-1.42.3 image build for the openstack-k8s-operators CI setup, preventing it from falling back to the older Go 1.24 default and aligning the CI image with the intended Go 1.26 toolchain.

The ci-build-root-golang-1.26-sdk-1.42.3 image was being built
without overriding GOLANG_BASE, so it defaulted to Go 1.24 from
the Dockerfile. Pass the Go 1.26 base image explicitly.

Jira: OSPRH-32127

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci
openshift-ci Bot requested review from abays and viroel July 7, 2026 07:21
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 59c4fb95-9fb8-42ad-8cb0-34ac9f930b65

📥 Commits

Reviewing files that changed from the base of the PR and between eb35ef3 and 2e4eb6c.

📒 Files selected for processing (1)
  • ci-operator/config/openstack-k8s-operators/openstack-k8s-operators-ci/openstack-k8s-operators-openstack-k8s-operators-ci-main.yaml

Walkthrough

Adds a new GOLANG_BASE build argument referencing a Go 1.26 OpenShift release image to the build-root images configuration in the CI operator YAML for openstack-k8s-operators.

Changes

CI Build Config Update

Layer / File(s) Summary
Add GOLANG_BASE build argument
ci-operator/config/openstack-k8s-operators/openstack-k8s-operators-ci/openstack-k8s-operators-openstack-k8s-operators-ci-main.yaml
Adds a GOLANG_BASE build argument set to registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.26-openshift-4.23 in the build-root images build config.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved, rehearsals-ack

Suggested reviewers: dprince, abays

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: explicitly passing GOLANG_BASE for the Go 1.26 CI build root image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only updates a CI operator YAML build arg; no Ginkgo tests or titles were added or modified.
Test Structure And Quality ✅ Passed The PR only updates CI YAML build args; no Ginkgo test code or test structure changes are present, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes ci-operator YAML build args; no Ginkgo tests, APIs, or MicroShift-relevant resources were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only changes CI image build args in a YAML config; no Ginkgo/e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only a CI image build config changed; it adds GOLANG_BASE and contains no scheduling, affinity, replicas, or topology logic.
Ote Binary Stdout Contract ✅ Passed PR only adds a GOLANG_BASE build arg in CI YAML; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator image config changed; no Ginkgo tests were added or modified, and the new base image points to internal registry.ci.openshift.org.
No-Weak-Crypto ✅ Passed Only change adds a GOLANG_BASE build arg in CI YAML; no weak-crypto algorithms, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed The PR only adds a GOLANG_BASE build arg to a ci-operator image config; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds a GOLANG_BASE build arg in a CI YAML; no logging statements or sensitive data exposure are present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stuggi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-openstack-k8s-operators-ci-main-images openstack-k8s-operators/openstack-k8s-operators-ci presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stuggi

stuggi commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-k8s-operators-ci-main-images

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stuggi

stuggi commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2026

@abays abays left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@stuggi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 71d8cb8 into openshift:main Jul 7, 2026
15 checks passed
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
…1527)

The ci-build-root-golang-1.26-sdk-1.42.3 image was being built
without overriding GOLANG_BASE, so it defaulted to Go 1.24 from
the Dockerfile. Pass the Go 1.26 base image explicitly.

Jira: OSPRH-32127

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants