[ospdo] Pass GOLANG_BASE for Go 1.26 CI build root image#81527
Conversation
The ci-build-root-golang-1.26-sdk-1.42.3 image was being built without overriding GOLANG_BASE, so it defaulted to Go 1.24 from the Dockerfile. Pass the Go 1.26 base image explicitly. Jira: OSPRH-32127 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new ChangesCI Build Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openstack-k8s-operators-openstack-k8s-operators-ci-main-images |
|
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@stuggi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…1527) The ci-build-root-golang-1.26-sdk-1.42.3 image was being built without overriding GOLANG_BASE, so it defaulted to Go 1.24 from the Dockerfile. Pass the Go 1.26 base image explicitly. Jira: OSPRH-32127 Signed-off-by: Martin Schuppert <mschuppert@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
The ci-build-root-golang-1.26-sdk-1.42.3 image was being built without overriding GOLANG_BASE, so it defaulted to Go 1.24 from the Dockerfile. Pass the Go 1.26 base image explicitly.
Jira: OSPRH-32127
Summary by CodeRabbit
Updated the OpenStack K8s Operators CI build-root image configuration so the Go 1.26 SDK image is explicitly used as the base. This fixes the
ci-build-root-golang-1.26-sdk-1.42.3image build for theopenstack-k8s-operatorsCI setup, preventing it from falling back to the older Go 1.24 default and aligning the CI image with the intended Go 1.26 toolchain.