Revert "openshift-ligthspeed: make the on pull request pipeline required before merging PR"

[raptorsun]

This reverts commit 34455a1.

Summary by CodeRabbit

Reverted the OpenShift Lightspeed Prow configuration change that made each repository’s pull-request CI check a required branch protection gate before merging.

This removes the enforced PR-required status checks from the affected Lightspeed repositories, restoring the previous merge behavior while leaving the rest of the Tide-based CI configuration intact.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8bf2d4e9-fa1d-4ca8-a8cb-bbc728a04c2a

📥 Commits

Reviewing files that changed from the base of the PR and between 1b55d5c and a40f185.

📒 Files selected for processing (6)

• core-services/prow/02_config/openshift/lightspeed-agentic-console/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-agentic-operator/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-agentic-sandbox/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-console/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-operator/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-service/_prowconfig.yaml

💤 Files with no reviewable changes (6)

• core-services/prow/02_config/openshift/lightspeed-console/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-agentic-console/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-agentic-operator/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-operator/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-service/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-agentic-sandbox/_prowconfig.yaml

---

Walkthrough

The branch-protection configuration blocks (protect: true and required_status_checks.contexts) were removed from six lightspeed-related Prow _prowconfig.yaml files under core-services/prow/02_config/openshift/, leaving only the tide sections in each file.

Changes

Branch-protection removal

Layer / File(s)	Summary
Remove branch-protection from lightspeed Prow configs core-services/prow/02_config/openshift/lightspeed-agentic-console/_prowconfig.yaml, .../lightspeed-agentic-operator/_prowconfig.yaml, .../lightspeed-agentic-sandbox/_prowconfig.yaml, .../lightspeed-console/_prowconfig.yaml, .../lightspeed-operator/_prowconfig.yaml, .../lightspeed-service/_prowconfig.yaml	Removed the branch-protection block (protect: true and required_status_checks.contexts for main) from each config, leaving only the tide query configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#81272: Adds back branch-protection blocks to the same lightspeed _prowconfig.yaml files that this PR removes.
• openshift/release#81291: Also removes branch-protection blocks and required status check contexts from Prow _prowconfig.yaml files.

Suggested labels: lgtm, approved, rehearsals-ack

Suggested reviewers: blublinsky, bparees

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes reverting the change that made the on-pull-request pipeline required before merge.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only edits Prow YAML configs; no Go/Ginkgo tests or test titles are changed, so the naming check is not applicable.
Test Structure And Quality	✅ Passed	PR only edits prowconfig YAML to remove branch-protection; no Ginkgo test files or test logic changed, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	Touched files are docs/config/tooling; 41 Go files changed, but none contain Ginkgo e2e entry points or MicroShift-sensitive tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo/e2e test definitions were changed; the PR only affects prow config/YAML and OWNERS files, so SNO compatibility isn’t applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Changed manifests only bump images or add a simple Deployment; no nodeSelector/affinity/topologySpreadConstraints/control-plane targeting were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes Prow YAML configs under core-services/prow/.../lightspeed*; no Go/binary process code or stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only edits prow config YAMLs; no new Ginkgo tests or networking code were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	Changed files are Prow YAML only; inspected them and found no weak-crypto primitives, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	PR only deletes branch-protection YAML in prow configs; no container/K8s manifest or privileged settings appear in the diff.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files are Prow YAML configs only; the targeted scan found no passwords, tokens, PII, or log strings in the modified files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[raptorsun]

/pj-rehearse auto-ack

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@raptorsun: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-bot]

@raptorsun: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@raptorsun: no rehearsable tests are affected by this change

[JoaoFula]

/lgtm

[kyoto]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoFula, kyoto, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift/lightspeed-agentic-console/OWNERS [kyoto,raptorsun]
• core-services/prow/02_config/openshift/lightspeed-agentic-operator/OWNERS [raptorsun]
• core-services/prow/02_config/openshift/lightspeed-agentic-sandbox/OWNERS [raptorsun]
• core-services/prow/02_config/openshift/lightspeed-console/OWNERS [kyoto]
• core-services/prow/02_config/openshift/lightspeed-operator/OWNERS [raptorsun]
• core-services/prow/02_config/openshift/lightspeed-service/OWNERS [raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@raptorsun: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-openshift-lightspeed-agentic-console-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-console/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-agentic-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-operator/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-agentic-sandbox-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-sandbox/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-console-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-console/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-operator/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-service-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-service/_prowconfig.yaml
• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-openshift-lightspeed-agentic-console-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-console/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-agentic-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-operator/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-agentic-sandbox-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-agentic-sandbox/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-console-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-console/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-operator/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-lightspeed-service-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-service/_prowconfig.yaml

Details

In response to this:

This reverts commit 34455a1.

Summary by CodeRabbit

Reverted the OpenShift Lightspeed Prow configuration change that made each repository’s pull-request CI check a required branch protection gate before merging.

This removes the enforced PR-required status checks from the affected Lightspeed repositories, restoring the previous merge behavior while leaving the rest of the Tide-based CI configuration intact.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.