Skip to content

Add odf-operator ci config for 4.23#81319

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
malayparida2000:odf_4_23
Jul 1, 2026
Merged

Add odf-operator ci config for 4.23#81319
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
malayparida2000:odf_4_23

Conversation

@malayparida2000

@malayparida2000 malayparida2000 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This update adds and refreshes CI configuration for the red-hat-storage/odf-operator repository to target OpenShift 4.23. It moves the main CI config to the newer 4.23 golang toolchain and updates the integration release target accordingly.

It also introduces a new 4.23 release-specific CI config that:

  • builds the operator and bundle images with the 4.23 toolchain,
  • wires in bundle/dependency catalog publishing behavior,
  • sets default resource requests for the generated jobs,
  • and adds a new AWS E2E pipeline that installs ODF and runs the end-to-end test flow.

Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c1198433-fa02-4ce3-a0c8-38dd9b64766c

📥 Commits

Reviewing files that changed from the base of the PR and between e3573a1 and a9737c4.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/red-hat-storage/odf-operator/red-hat-storage-odf-operator-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-main.yaml
  • ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-release-4.23.yaml

Walkthrough

Updates the odf-operator main CI config to reference the OpenShift 4.23/Go 1.26 build root and bumps the integration release name to 4.23. Adds a new red-hat-storage-odf-operator-release-4.23.yaml defining build root, images, bundle/catalog builds, resource defaults, and an E2E AWS test pipeline.

Changes

ODF Operator 4.23 CI Configuration

Layer / File(s) Summary
Main config toolchain and integration bump
ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-main.yaml
Bumps build root image stream tag to rhel-9-release-golang-1.26-openshift-4.23 and updates releases.latest.integration.name to "4.23".
Release 4.23 build root and images
ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-release-4.23.yaml
New file defines build root using the 4.23 toolchain and an images section building odf-operator and odf-dependencies-bundle.
Bundle/catalog and release integration metadata
ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-release-4.23.yaml
Configures bundle and dependency catalog builds with index building skipped, pullspec-to-pipeline substitutions, release integration name/namespace (4.23/ocp), and default CPU/memory resource requests.
E2E AWS test pipeline and metadata
ci-operator/config/red-hat-storage/odf-operator/red-hat-storage-odf-operator-release-4.23.yaml
Adds odf-operator-e2e-aws test with AWS cluster profile, environment variables, unit-test and E2E stages, plus generated branch/org/repo metadata.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: lgtm, approved, ok-to-test, rehearsals-ack

Suggested reviewers: obnoxxx

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding odf-operator CI configuration for OpenShift 4.23.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes CI YAML; the test-like labels are static (odf-operator-e2e-aws, unit-tests, e2e-tests) and no Ginkgo titles or dynamic values appear.
Test Structure And Quality ✅ Passed Only ci-operator YAML changed; no Ginkgo test code or fixtures were added, so the test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only CI YAML changed; no new Ginkgo test code was added, and the new job targets ipi-aws, not MicroShift.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Config-only 4.23 bump; the e2e job is unchanged from 4.22 and no new Ginkgo tests or SNO-unsafe assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator YAML changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PASS: The PR only changes ci-operator YAML for odf-operator; no process-level code or logging changes that could write non-JSON stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo specs were added; the new 4.23 CI job reuses existing e2e commands and has no hardcoded IPv4 or public-internet calls.
No-Weak-Crypto ✅ Passed The only changed files are CI YAMLs; they contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom secret comparisons.
Container-Privileges ✅ Passed No privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings appear; the diff only updates toolchain, release target, and branch.
No-Sensitive-Data-In-Logs ✅ Passed Changed CI configs only define test commands/env vars; no passwords, tokens, keys, PII, or logging statements that would expose them.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from agarwal-mudit and obnoxxx July 1, 2026 10:07
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@malayparida2000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-red-hat-storage-odf-operator-release-4.23-ci-bundle-odf-dependencies-catalog red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.23-ci-bundle-odf-operator-bundle red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.23-images red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.23-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-main-ci-bundle-odf-dependencies-catalog red-hat-storage/odf-operator presubmit Ci-operator config changed
pull-ci-red-hat-storage-odf-operator-main-ci-bundle-odf-operator-bundle red-hat-storage/odf-operator presubmit Ci-operator config changed
pull-ci-red-hat-storage-odf-operator-main-images red-hat-storage/odf-operator presubmit Ci-operator config changed
pull-ci-red-hat-storage-odf-operator-main-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@malayparida2000

Copy link
Copy Markdown
Contributor Author

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@malayparida2000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@malayparida2000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@iamniting

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@iamniting: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 1, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 842e4b4 into openshift:main Jul 1, 2026
24 checks passed
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
smulje pushed a commit to smulje/release that referenced this pull request Jul 9, 2026
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants